From c2531d53286d2d5be4f58bd44fcacf96ba056057 Mon Sep 17 00:00:00 2001 From: Anatoli Papirovski Date: Tue, 2 Jan 2018 11:45:21 -0500 Subject: [PATCH 1/2] test: fix flaky test-http-highwatermark --- ...st-http-hightwatermark.js => test-http-highwatermark.js} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename test/parallel/{test-http-hightwatermark.js => test-http-highwatermark.js} (91%) diff --git a/test/parallel/test-http-hightwatermark.js b/test/parallel/test-http-highwatermark.js similarity index 91% rename from test/parallel/test-http-hightwatermark.js rename to test/parallel/test-http-highwatermark.js index b2432227a9d5f5..1e69662d00f13a 100644 --- a/test/parallel/test-http-hightwatermark.js +++ b/test/parallel/test-http-highwatermark.js @@ -14,7 +14,7 @@ let requestReceived = 0; const server = http.createServer(function(req, res) { const id = ++requestReceived; const enoughToDrain = req.connection.writableHighWaterMark; - const body = 'x'.repeat(enoughToDrain); + const body = 'x'.repeat(enoughToDrain * 100); if (id === 1) { // Case of needParse = false @@ -39,11 +39,11 @@ const server = http.createServer(function(req, res) { }).on('listening', () => { const c = net.createConnection(server.address().port, () => { c.write('GET / HTTP/1.1\r\n\r\n'); - c.write('GET / HTTP/1.1\r\n\r\n'); + c.write('GET / HTTP/1.1\r\n\r\n', + () => setImmediate(() => c.on('data', () => {}))); c.end(); }); - c.on('data', () => {}); c.on('end', () => { server.close(); }); From 1408c3f577210ffb4653cade9a3dacd3efbb685f Mon Sep 17 00:00:00 2001 From: Anatoli Papirovski Date: Tue, 2 Jan 2018 23:06:52 -0500 Subject: [PATCH 2/2] fixup: nits --- test/parallel/test-http-highwatermark.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-http-highwatermark.js b/test/parallel/test-http-highwatermark.js index 1e69662d00f13a..79d9c46a558b60 100644 --- a/test/parallel/test-http-highwatermark.js +++ b/test/parallel/test-http-highwatermark.js @@ -40,7 +40,7 @@ const server = http.createServer(function(req, res) { const c = net.createConnection(server.address().port, () => { c.write('GET / HTTP/1.1\r\n\r\n'); c.write('GET / HTTP/1.1\r\n\r\n', - () => setImmediate(() => c.on('data', () => {}))); + () => setImmediate(() => c.resume())); c.end(); });