Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve module.builtinModules text #17865

Closed
wants to merge 1 commit into from
Closed

doc: improve module.builtinModules text #17865

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 25, 2017

module is maintained by a third-party module seems confusing. Changed
to module is maintained by a third-party.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc module

@Trott Trott added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Dec 25, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Dec 25, 2017
TimothyGu
TimothyGu reviewed Dec 26, 2017
View reviewed changes
doc/api/modules.md Outdated
@@ -839,7 +839,7 @@ added: v9.3.0
* {string[]}

A list of the names of all modules provided by Node.js. Can be used to verify
if a module is maintained by a third-party module or not.
if a module is maintained by a third-party or not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/-/ / for the noun instead of adjective

@Trott
doc: improve module.builtinModules text
e92e992 
`module is maintained by a third-party module` seems confusing. Changed
to `module is maintained by a third-party`.
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 26, 2017
jasnell pushed a commit that referenced this pull request Dec 28, 2017
@Trott @jasnell
doc: improve module.builtinModules text
62a44a3 
`module is maintained by a third-party module` seems confusing. Changed
to `module is maintained by a third-party`.

PR-URL: #17865
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 28, 2017

Landed in 62a44a3

@jasnell jasnell closed this Dec 28, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott @MylesBorins
doc: improve module.builtinModules text
0d58df4 
`module is maintained by a third-party module` seems confusing. Changed
to `module is maintained by a third-party`.

PR-URL: #17865
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: improve module.builtinModules text
ef79ff0 
`module is maintained by a third-party module` seems confusing. Changed
to `module is maintained by a third-party`.

PR-URL: #17865
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott @MylesBorins
doc: improve module.builtinModules text
cb127de 
`module is maintained by a third-party module` seems confusing. Changed
to `module is maintained by a third-party`.

PR-URL: #17865
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@Trott Trott deleted the module-typo branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@starkwang starkwang starkwang approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.