test: adding Countdown to test-http-incoming-pipelined-socket-destroy.js #17506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
approved these changes
Dec 6, 2017
maclover7
approved these changes
Dec 7, 2017
idandagan1
changed the title
lpinca
approved these changes
Dec 7, 2017
maclover7
added
the
author ready
apapirovski
reviewed
Dec 8, 2017
|
|
||
| const http = require('http'); | ||
| const net = require('net'); | ||
|
|
There was a problem hiding this comment.
Hi @idandagan1 — one little change before this lands, could you re-insert this line break between the requires and the rest of the code?
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
CI: 20d6b8c Thanks for the contribution @idandagan1! Congrats on becoming a Contributor! 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax
removed
the
author ready
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17506 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
My first PR to NodeJS.
Added Countdown to test-http-incoming-pipelined-socket-destroy.js :
#17169
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
#goodnessSquad