Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Replace string with template string #17316

Closed
wants to merge 1 commit into from
Closed

doc: Replace string with template string #17316

wants to merge 1 commit into from

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Nov 26, 2017

This is part of Nodefest's Code and Learn nodejs/code-and-learn#72

I replace string with template string in doc/api/stream.md.

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 26, 2017
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-commit/14362/

@joyeecheung joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
jasnell
jasnell approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure in CI is unrelated.

jasnell pushed a commit that referenced this pull request Nov 26, 2017
@Leko @jasnell
doc: replace string with template string
76dbde1 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in 76dbde1. Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 26, 2017
@Leko Leko deleted the replace_with_template_string_in_stream_doc branch November 27, 2017 06:18
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
doc: replace string with template string
4bc558a 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Leko @MylesBorins
doc: replace string with template string
2bd241e 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Leko @gibfahn
doc: replace string with template string
c5fdc53 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Leko @gibfahn
doc: replace string with template string
c519287 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Leko @gibfahn
doc: replace string with template string
7b7ab9c 
PR-URL: #17316
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@maclover7 maclover7 maclover7 approved these changes

@targos targos targos approved these changes

@watilde watilde watilde approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.