Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix compiler warning #17195

Closed
wants to merge 1 commit into from
Closed

src: fix compiler warning #17195

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 21, 2017

This commit fixes a -Winconsistent-missing-override warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@cjihrig
src: fix compiler warning
c292001 
This commit fixes a -Winconsistent-missing-override warning.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Nov 21, 2017
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

This shouldn't need to wait the 48 hours to land once it passes CI

@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11587/

jasnell pushed a commit that referenced this pull request Nov 21, 2017
@cjihrig @jasnell
src: fix compiler warning
bb31a16 
This commit fixes a -Winconsistent-missing-override warning.

PR-URL: #17195
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in bb31a16

@jasnell jasnell closed this Nov 21, 2017
@cjihrig cjihrig deleted the warning branch November 21, 2017 17:51
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@cjihrig @MylesBorins
src: fix compiler warning
0b12884 
This commit fixes a -Winconsistent-missing-override warning.

PR-URL: #17195
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@cjihrig @gibfahn
src: fix compiler warning
096bd53 
This commit fixes a -Winconsistent-missing-override warning.

PR-URL: #17195
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@cjihrig @gibfahn
src: fix compiler warning
76f63b5 
This commit fixes a -Winconsistent-missing-override warning.

PR-URL: #17195
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @jasnell @refack @joyeecheung @gibfahn @nodejs-github-bot