Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: remove emit micro-optimizations #16869

Closed
wants to merge 3 commits into from
Closed

events: remove emit micro-optimizations #16869

wants to merge 3 commits into from

Commits on Nov 7, 2017

  1. events: remove emit micro-optimizations 

    With improvements in V8, using separate emit functions is no longer
necessary and can instead be replaced by the spread operator.

improvement                             confidence        p.value
events/ee-emit.js n=2000000                 2.98 %        0.09852489
events/ee-emit-2-args.js n=2000000          4.19 %    *** 0.0001914216
events/ee-emit-6-args.js n=2000000         61.69 %    *** 6.611964e-35
events/ee-emit-diff-args.js n=2000000      -0.36 %        0.305069
events/ee-once.js n=20000000                6.42 %    *** 1.27831e-06
    @apapirovski
    apapirovski committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    b659275 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2017

  1. [fixup] more flexible emit benchmark

    @apapirovski
    apapirovski committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    8b95f82 View commit details
    Browse the repository at this point in the history

  2. [fixup] do not bind or apply args

    @apapirovski
    apapirovski committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    7ddf389 View commit details
    Browse the repository at this point in the history