First time contribution from NodeConf EU #16821
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
node-api
| assert.strictEqual(addon.testNapiRun('(41.92 + 0.08);'), 42, | ||
| 'napi_run_script() works correctly'); | ||
| assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/); | ||
| const args = [41.92, 0.08]; |
There was a problem hiding this comment.
This would be a bit nicer as just, say:
const val1 = 41.92;
const val2 = 0.08;| const args = [41.92, 0.08]; | ||
| const testCase = '(' + args.join(' + ') + ');'; | ||
| const expected = 43; | ||
| const actual = addon.testNapiRun(testCase); |
There was a problem hiding this comment.
This could be then rewritten as:
const actual = addon.testNapiRun(`(${val1} + ${val2});`);| assert.throws(() => addon.testNapiRun({ abc: 'def' }), /string was expected/); | ||
| const args = [41.92, 0.08]; | ||
| const testCase = '(' + args.join(' + ') + ');'; | ||
| const expected = 43; |
There was a problem hiding this comment.
This could then be const expected = val1 + val2;
| const expected = 43; | ||
| const actual = addon.testNapiRun(testCase); | ||
|
|
||
| assert.strictEqual(actual, expected, `testNapiRun${testCase} gets ${actual} not expected ${expected}`); |
There was a problem hiding this comment.
Here you could remove the third argument (the error message) as the default message communicates the same thing.
apapirovski
added
the
code-and-learn
|
@paulashfield - on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
|
@paulashfield See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
| const actual = addon.testNapiRun(testCase); | ||
|
|
||
| assert.strictEqual(actual, expected, `testNapiRun${testCase} gets ${actual} not expected ${expected}`); | ||
| assert.throws(() => addon.testNapiRun({abc: 'def'}), /string was expected/); |
There was a problem hiding this comment.
A nit: the last line seems lacking the last line break.
|
Many thanks all for feedback - really helped. I have amended and recommitted, hope that looks better. |
|
Hi @paulashfield! Welcome and thanks for the PR! If you run |
PR-URL: nodejs#16821 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 3ee524b. |
PR-URL: #16821 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
@paulashfield just an FYI, this commit isn't associated with your Github account. You need to go to https://github.com/settings/emails and add That's why there's a
|
PR-URL: #16821 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs#16821 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Backport-PR-URL: #19447 PR-URL: #16821 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)