Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Http2Stream redundant call to shutdown and call passing only callback #15612

Closed
wants to merge 1 commit into from
Closed

test: Http2Stream redundant call to shutdown and call passing only callback #15612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions test/parallel/test-http2-server-shutdown-redundant.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');

const server = http2.createServer();

// Test blank return when a stream.session.shutdown is called twice
// Also tests stream.session.shutdown with just a callback function (no options)
server.on('stream', common.mustCall((stream) => {
stream.session.shutdown(common.mustCall(() => {
assert.strictEqual(
stream.session.shutdown(common.mustNotCall()),
undefined
);
}));
stream.session.shutdown(common.mustNotCall());
}));

server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);

const req = client.request();
req.resume();
req.on('end', common.mustCall(() => server.close()));
}));