-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: don't fail make test
on source tarballs
#15441
Conversation
Tries to achieve the same effect as nodejs#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! Fixes: nodejs#14513
cc/ @jellelicht @vsemozhetbyt @joaocgreis, is this a reasonable compromise? |
I would be extremely happy if this is merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in 66e45b8 |
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
This should be backported to 6.x, as it's essentially a fix for people using |
Also @BridgeAR this landed without CI. |
@gibfahn right, that slipped through. I make sure it will run next time. |
Tries to achieve the same effect as nodejs#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: nodejs#15441 Fixes: nodejs#14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Tries to achieve the same effect as nodejs/node#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: nodejs/node#15441 Fixes: nodejs/node#14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
cherry-picked cleanly @gibfahn |
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if
tools/eslint
wasn't there at all, people would notice in the PR review!Fixes: #14513
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build