From b45366132fc5c98ecba8def6ac731d50475161e5 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Fri, 18 Aug 2017 23:09:14 -0700 Subject: [PATCH 1/2] doc: remove `you` and fixup note in stream.md --- doc/api/stream.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index 3663fe2d780830..da3323df125263 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1445,9 +1445,9 @@ added: v8.0.0 --> * `callback` {Function} Call this function (optionally with an error - argument) when you are done writing any remaining data. + argument) when finished writing any remaining data. -Note: `_final()` **must not** be called directly. It MAY be implemented +*Note*: `_final()` **must not** be called directly. It MAY be implemented by child classes, and if so, will be called by the internal Writable class methods only. From a1d8908e4383f3112a5218c002f978d5f543f9c3 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sun, 20 Aug 2017 09:25:22 -0700 Subject: [PATCH 2/2] [Squash] address minor nit --- doc/api/stream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/stream.md b/doc/api/stream.md index da3323df125263..6497a60ffeea4c 100644 --- a/doc/api/stream.md +++ b/doc/api/stream.md @@ -1447,7 +1447,7 @@ added: v8.0.0 * `callback` {Function} Call this function (optionally with an error argument) when finished writing any remaining data. -*Note*: `_final()` **must not** be called directly. It MAY be implemented +The `_final()` method **must not** be called directly. It may be implemented by child classes, and if so, will be called by the internal Writable class methods only.