8.1.0 Proposal #13483
Closed
8.1.0 Proposal #13483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this test will fail with the following error message when configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit checks for crypto and skips this tests if such support is not available. PR-URL: #13253 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
When V8 is built from its master branch, it adds a " (candidate)" suffix to the version string. Add support for that in the tests so it does not fail with Node canary. PR-URL: #13282 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Allow binding to a randomly assigned port number with `--inspect=0` or `--inspect-brk=0`. PR-URL: #5025 Refs: #4419 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
BUILDING.md + L122: Missing code-language flag + L170: Strong should use `*` as a marker doc/changelogs/CHANGELOG_V6.md + L1494: Don't pad `emphasis` with inner spaces doc/guides/maintaining-V8.md + L3: Don't use multiple top level headings + L16: Don't use multiple top level headings + L40: Don't use multiple top level headings + L124: Don't use multiple top level headings + L182: Missing code-language flag + L223: Don't use multiple top level headings + L288: Don't use multiple top level headings + L307: Don't use multiple top level headings doc/guides/writing-tests.md + L322: Missing code-language flag + L329: Missing code-language flag doc/releases.md + L299: Missing code-language flag PR-URL: #13270 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. PR-URL: #13244 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
One of the N-API weak-reference test cases already had to be made asynchronous to handle different behavior in a newer V8 version: #12864 When porting N-API to Node-ChakraCore, we found more of the test cases needed similar treatment: nodejs/node-chakracore#246 So to make thes tests more robust (and avoid having differences in the test code for Node-ChakraCore), I am refactoring the tests in this file to insert a `setImmedate()` callback before every call to `gc()` and assertions about the effects of the GC. PR-URL: #13121 Reviewed-By: Michael Dawson <[email protected]>
Use `common.mustNotCall()` in test-stream2-objects.js to confirm that noop function is never invoked. PR-URL: #13249 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
On macOS, a watcher created with fs.watch() does not necessarily start receiving events immediately. So it can miss a change by fs.writefile() if it comes very soon after the watcher is created. Fix test flakiness caused by this by using `setInterval()` to repeat the write action. PR-URL: #13252 Fixes: #13248 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #13323 Reviewed-By: Luigi Pinca <[email protected]>
Re-enable test-http-abort-stream-end and put it into parallel category. Use system random port when calling server.listen() and fix eslint errors. After calling request.abort(), in order to avoid the buffered data to trigger the 'data' event, explicitly remove 'data' event listeners. PR-URL: #13260 Reviewed-By: Brian White <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Functions that call `ECDH::BufferToPoint` were not clearing the error stack on failure, so an invalid key could leave leftover error state and cause subsequent (unrelated) signing operations to fail. PR-URL: #13275 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
Use `common.mustCall()` to make sure noop function is called as expected. PR-URL: #13259 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added option to expose engine to convenience methods Refs: #8874 PR-URL: #13089 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Added bytesRead property to Zlib engines Fixes: #8874 PR-URL: #13088 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
* Update outputs. * Refine spaces. * Restore missing part. PR-URL: #13288 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
* Use common.mustNotCall() and common.mustCall() as appropriate * Use block scoping * Move assertions out of `exit` handler and into callbacks * Order assert.strictEqual() args per docs * Remove console.log() calls * Move test from `parallel` to `sequential` so `common.PORT` can be used without conflicting with OS-provided ports in other `parallel` tests PR-URL: #13273 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
* Remove useless constructor. * Use template literals. * Update code example. Now all arrays with just holes are outputted the same way. In the fixed example, it was `[ <101 empty items> ]` twice. PR-URL: #13298 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #13371 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Previously, napi_wrap() would only work with objects created from a constructor returned by napi_define_class(). While the N-API team was aware of this limitation, it was not clearly documented and is likely to cause confusion anyway. It's much simpler if addons are allowed to use any JS object. Also, the specific behavior of the limitation is difficult to reimplement on other VMs that work differently from V8. V8 requires object internal fields to be declared on the object prototype (which napi_define_class() used to do). Since it's too late to modify the object prototype by the time napi_wrap() is called, napi_wrap() now inserts a new object (with the internal field) into the supplied object's prototype chain. Then it can be retrieved from there later by napi_unwrap(). This change also includes improvements to the documentation for napi_create_external(), partly to explain how it is different from napi_wrap(). PR-URL: #13250 Reviewed-By: Michael Dawson <[email protected]>
Author: Thorsten Lorenz <[email protected]> Author: Andreas Madsen <[email protected]> PR-URL: #13287 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Fixes #13356 PR-URL: #13360 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
It takes time to build each of the addons used to test n-api. Consolidate a few of the smaller ones to save build time. PR-URL: #13317 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: #13319 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #13379 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #13316 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vladimir Kurchatkin <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
PR-URL: #13313 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The test is flaky under load. These changes greatly improve reliability. * Use a recurring interval to determine when the test should end rather than a timer. * Increase server timeout to 500ms to allow for events being delayed by system load Changing to an interval has the added benefit of reducing the test run time from over 2 seconds to under 1 second. Fixes: #13307 PR-URL: #13312 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
Pure refactor, makes no functional changes but the renaming helped me
see more clearly what the relationship was between methods and
variables.
* Renamed methods to reduce number of slightly different names for the
same thing ("thread" vs "io thread", etc.).
* Added comments where it was useful to me.
PR-URL: #13321
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gpg 2.1 no longer includes the key-id by default which breaks the release script. This makes sure we are explicit about it. PR-URL: #13309 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #13411 Refs: #13385 Refs: #13248 Refs: #13377 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
test: changed test2 of test-vm-timeout.js so that entire error message
would be matched in assert.throw.
Before test 2 of test-vm-timeout.js would match any RangeError,
now it looks specifically for the error message
"RangeError: timeout must be a positive number"
test: changed test 3 of test-vm-timeout.js so that entire error message
would be matched in assert.throw.
Before test 3 of test-vm-timeout.js would match any RangeError,
now it looks specifically for the error message
"RangeError: timeout must be a positive number"
PR-URL: #13453
Refs: #13454
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
The libuv 1.12.0 update bumped the minimum supported version of linux + glibc. This commit updates BUILDING.md to reflect the new values. PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Makes the same changes as 9946173 to update the test runner for npm5. PR-URL: #13441 Refs: #12936 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Allows NODE_TEST_DIR to be set (necessary to avoid path length issues with common.PIPE). PR-URL: #13390 Refs: #12708 (comment) Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #2883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Introduce two overridable `Agent` methods: * `keepSocketAlive(socket)` * `reuseSocket(socket, req)` These methods can be overridden by particular `Agent` class child to make keep-alive behavior customizable. Motivation: destroy persisted sockets after some configurable timeout. It is very non-trivial to do it with available primitives. Such program will most likely need to poke with undocumented events and methods of `Agent`. With introduced API such behavior is easy to implement. PR-URL: #13005 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
* Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. PR-URL: #13443 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #13481 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Brian White <[email protected]>
PR-URL: #13173 Fixes: #8276 Refs: #12607 Refs: #12818 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]>
Fixes: #12853 Fixes: #854 PR-URL: #13306 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/8544/ Note: this includes both the npm and libuv updates |
|
Appologies if this was planned for today, were having an infra outage atm that will make it difficult nodejs/build#749, will update here when were through. |
|
Ugh. Ok, thank you for the heads up. I'll do the iojs+release build tomorrow! It'll be quite a bit later in the day, however, since I will be chaperoning a field trip for my kids school. The release proposal should be just about ready to go in the 8.1.0-proposal branch if anyone would like to take it over tomorrow to get the release out earlier. The only remaining todo before actually cutting the release, tagging and promoting is to update the changelog one more time. |
|
(note, if anyone does want to pick this up tomorrow, then keep in mind that this PR is currently pointing at my personal fork... I just pushed the 8.1.0-proposal branch to the nodejs/node repo) |
|
I could do it when everything gets back online so we stick with the schedule you'd prepped people with. |
|
Sounds good. I'll be up fairly late tonight so feel free to ping if any issues or questions come up. Note that the Working On 8.1.1 commit is already in so take care when tagging. |
|
I'm not happy with the look of the citgm failures on ftp and yeoman-generator across multiple platforms. There's also a segfault for ffi on debian8 and a weird assertion failure for thread-sleep on aix. Running some more variations to understand whether these are real problems or not. |
|
Confirmed that the failures are consistent with 8.0.0, does anyone know if these are being followed up? They're not happy-looking failures. Moving ahead but now shaving yaks with the ARM cluster, odd filesystem errors so I've had to restart a bunch of things. |
* **Async Hooks**
* When one `Promise` leads to the creation of a new `Promise`, the parent
`Promise` will be identified as the trigger
[[`135f4e6643`](135f4e6643)]
[#13367](#13367).
* **Dependencies**
* libuv has been updated to 1.12.0
[[`968596ec77`](968596ec77)]
[#13306](#13306).
* npm has been updated to 5.0.3
[[`ffa7debd7a`](ffa7debd7a)]
[#13487](#13487).
* **File system**
* The `fs.exists()` function now works correctly with `util.promisify()`
[[`6e0eccd7a1`](6e0eccd7a1)]
[#13316](#13316).
* fs.Stats times are now also available as numbers
[[`c756efb25a`](c756efb25a)]
[#13173](#13173).
* **Inspector**
* It is now possible to bind to a random port using `--inspect=0`
[[`cc6ec2fb27`](cc6ec2fb27)]
[#5025](#5025).
* **Zlib**
* A regression in the Zlib module that made it impossible to properly
subclasses `zlib.Deflate` and other Zlib classes has been fixed.
[[`6aeb555cc4`](6aeb555cc4)]
[#13374](#13374).
PR-URL: #13483
|
Done, tested, yaks shaved, built and promoted. Needed some REPLACEME fixes but commits were all good aside from that. Still missing are:
These binaries will have to be promoted later, probably not for at least another 12 hours from now unfortunately. |
|
armv6 successfully in progress, I've had to disconnect the aix ppc machine from release jenkins as it was causing a weird error preventing any more builds at all. When we have the aix machines all back online (they are offline for test too, hence the queue there), I'll reattach it and rebuild. |
|
Release commit in d7f6919, can this be closed? |
|
Yep! |
|
aix and armv6 binaries released and release post updated, so we're all done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js 8.1.0 Proposal
/cc @nodejs/release
Notable Changes
Promiseleads to the creation of a newPromise, the parentPromisewill be identified as the trigger[
135f4e6643]#13367.
fs.exists()function now works correctly withutil.promisify()[
6e0eccd7a1]#13316.
--inspect=0[
cc6ec2fb27]#5025.
subclasses
zlib.Deflateand other Zlib classes has been fixed.[
6aeb555cc4]#13374.
Commits
47c9de9842] - assert: fix deepEqual RangeError: Maximum call stack size exceeded (rmdm) #13318135f4e6643] - (SEMVER-MINOR) async_hooks: use parent promise as triggerId (JiaLi.Passion) #133679db02dcc85] - async_hooks,http: fix socket reuse with Agent (Anna Henningsen) #133486917df2a80] - async_wrap: run destroy in uv_timer_t (Trevor Norris) #13369291669e7d8] - build: streamline JS test suites in Makefile (Rich Trott) #13340dcadeb4fef] - build: fix typo (Nikolai Vavilov) #1339650b5f8bac0] - crypto: clear err stack after ECDH::BufferToPoint (Ryan Kelly) #13275035a81b2e6] - deps: update openssl asm and asm_obsolete files (Daniel Bevenius) #132336f57554650] - deps: update openssl config files (Daniel Bevenius) #132331b8b82d076] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836783294add1] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389db7419bead] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389dd93fa677a] - deps: copy all openssl header files to include dir (Daniel Bevenius) #13233d9191f6e18] - deps: upgrade openssl sources to 1.0.2l (Daniel Bevenius) #1323392de432780] - dns: use faster IP address type check on results (Brian White) #13261007a033820] - dns: improve callback performance (Brian White) #13261414da1b7a1] - doc: fix nits in code examples of async_hooks.md (Vse Mozhet Byt) #13400159294d7d5] - doc: use prefer-rest-params eslint rule in docs (Vse Mozhet Byt) #13389641979b213] - doc: resume a stream after pipe() and unpipe() (Matteo Collina) #133296c56bbdf13] - doc: add missing backticks to doc/api/tls.md (Paul Bininda) #13394837ecc01eb] - doc: update who to cc for async_hooks (Anna Henningsen) #1333252c0c47856] - doc: suggest xcode-select --install (Gibson Fahnestock) #1326411e428dd99] - doc: add require modules in url.md (Daijiro Wachi) #133652d25e09b0f] - doc: add object-curly-spacing to doc/.eslintrc (Vse Mozhet Byt) #133546cd5312b22] - doc: unify spaces in object literals (Vse Mozhet Byt) #133544e687605ee] - doc: use destructuring in code examples (Vse Mozhet Byt) #133491b192f936a] - doc: fix code examples in zlib.md (Vse Mozhet Byt) #13342a872399ddb] - doc: update who to cc for n-api (Michael Dawson) #1333590417e8ced] - doc: add missing make command to UPGRADING.md (Daniel Bevenius) #132333c55d1aea4] - doc: refine spaces in example from vm.md (Vse Mozhet Byt) #133341729574cd7] - doc: fix link in CHANGELOG_V8 (James, please) #1331316605cc3e4] - doc: add async_hooks, n-api to _toc.md and all.md (Vse Mozhet Byt) #13379eb6e9a0c9a] - doc: remove 'you' from writing-tests.md (Michael Dawson) #13319e4f37568e2] - doc: fix date for 8.0.0 changelog (Myles Borins) #1336041f0af524d] - doc: async-hooks documentation (Thorsten Lorenz) #13287b8b0bfb1a7] - doc: add tniessen to collaborators (Tobias Nießen) #13371561c14ba12] - doc: modernize and fix code examples in util.md (Vse Mozhet Byt) #13298c2d7b41ac7] - doc: fix code examples in url.md (Vse Mozhet Byt) #13288243643e5e4] - doc: fix typo in n-api.md (JongChan Choi) #13323bee1421501] - doc: fix doc styles (Daijiro Wachi) #1327044c8ea32df] - doc,stream: clarify 'data', pipe() and 'readable' (Matteo Collina) #134326e0eccd7a1] - (SEMVER-MINOR) fs: promisify exists correctly (Dan Fabulich) #13316b3c9bff254] - http: describe parse err in debug output (Sam Roberts) #13206c7ebf6ea70] - http: suppress data event if req aborted (Yihong Wang) #13260376ac5fc3e] - inspector: Allows reentry when paused (Eugene Ostroukhov) #133507f0aa3f4bd] - inspector: refactor to rename and comment methods (Sam Roberts) #13321cc6ec2fb27] - (SEMVER-MINOR) inspector: bind to random port with --inspect=0 (Ben Noordhuis) #5025a95f080160] - n-api: enable napi_wrap() to work with any object (Jason Ginchereau) #13250b5409abf9a] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#138981ddeb98f6] - readline: clean up event listener in onNewListener (Gibson Fahnestock) #132668620aad573] - src: added newline in help message (Josh Ferge) #13315339d220eed] - test: rearrange inspector headers into convention (Sam Roberts) #134288c7f9da489] - test: improve async hooks test error messages (Anna Henningsen) #13243818c935add] - test: test async-hook triggerId properties (Dávid Szakállas) #1332829f19b6d39] - test: add documentation for common.mustNotCall() (Rich Trott) #13359c208f9d51f] - test: check destroy hooks are called before exit (Anna Henningsen) #13369406c2cd8e4] - test: make test-fs-watchfile reliable (Rich Trott) #1338593e91a4f3f] - test: check inspector support in test/inspector (Daniel Bevenius) #13324d1b39d92d6] - test: add known_test request with Unicode in the URL (David D Lowe) #13297dccd1d2d31] - test: improve dns internet test case (Brian White) #13261e20f3577d0] - test: improve test-https-server-keep-alive-timeout (Rich Trott) #133122a29c07d9e] - test: mark inspector-port-zero-cluster as flaky (Refael Ackermann)b16dd98387] - test: consolidate n-api test addons (Michael Dawson) #13317830049f784] - test: refactor test-net-server-bind (Rich Trott) #132739df8e2a3e9] - test: use mustCall() in test-readline-interface (Rich Trott) #1325925a05e5db1] - test: fix flaky test-fs-watchfile on macOS (Rich Trott) #13252ec357bf88f] - test: use mustNotCall() in test-stream2-objects (Rich Trott) #132495369359d52] - test: Make N-API weak-ref GC tests asynchronous (Jason Ginchereau) #131217cc6fd8403] - test: improve n-api coverage for typed arrays (Michael Dawson) #13244a2d49545a7] - test: support candidate V8 versions (Michaël Zasso) #13282f0ad3bb695] - test: hasCrypto https-server-keep-alive-timeout (Daniel Bevenius) #13253bccda4f2b8] - tools: be explicit about including key-id (Myles Borins) #13309d4d138c6e9] - url: do not pass WHATWG host to http.request (Tobias Nießen) #13409315c3aaf43] - url: more precise URLSearchParams constructor (Timothy Gu) #130261bcda5efda] - util: refactor format method.Performance improved. (Jesus Seijas) #124076aeb555cc4] - zlib: revert back to Functions (James M Snell) #13374cc3174a937] - (SEMVER-MINOR) zlib: expose amount of data read for engines (Alexander O'Mara) #13088bb77d6c1cc] - (SEMVER-MINOR) zlib: option for engine in convenience methods (Alexander O'Mara) #13089