fs: expose Stats times as Numbers #13257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
2 tasks
mscdex
reviewed
May 28, 2017
| assert.strictEqual(false, s.isSymbolicLink()); | ||
|
|
||
| assert.ok(s.atime instanceof Date); |
There was a problem hiding this comment.
Replaced with loop assertion by type in https://github.com/nodejs/node/pull/13257/files/945a3daef53397d6d3ec97f56bcb4d24b71c6304#diff-3f8f036a4652d356be0e5108f2371fe1R97
refack
force-pushed
the
mild-revert-9836cf5
branch
from
945a3da
to
b6c9123
Compare
|
Added a test case. New CI:https://ci.nodejs.org/job/node-test-commit/10200/ |
This also reverts commit 9836cf5. Fixes: npm/npm#16734 Ref: nodejs#12607 Ref: nodejs#12818
refack
force-pushed
the
mild-revert-9836cf5
branch
from
b6c9123
to
d88342b
Compare
4 tasks
|
Superseded by #13256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #13173
for aftr the revert of commit 9836cf5.
Depends on #13256
Expose Stats times as Numbers
also set Date cache fields in constructor
Fixes: #8276
Fixes: #13255
Ref: #12607
Ref: #12818
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs