-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zlib: expose amount of data read for engines #13088
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7aa6e2b
zlib: expose amount of data read for engines
AlexanderOMara df6c1f0
zlib: document engine bytesRead property
AlexanderOMara cf58570
zlib: refactored bytesRead test to use callbacks
AlexanderOMara f5a87d6
zlib: expanded bytesRead property description
AlexanderOMara 6c1a1e9
zlib: added bytesRead YAML comment
AlexanderOMara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const zlib = require('zlib'); | ||
|
||
const expectStr = 'abcdefghijklmnopqrstuvwxyz'.repeat(2); | ||
const expectBuf = Buffer.from(expectStr); | ||
|
||
function createWriter(target, buffer) { | ||
const writer = { size: 0 }; | ||
const write = () => { | ||
target.write(Buffer.from([buffer[writer.size++]]), () => { | ||
if (writer.size < buffer.length) { | ||
target.flush(write); | ||
} else { | ||
target.end(); | ||
} | ||
}); | ||
}; | ||
write(); | ||
return writer; | ||
} | ||
|
||
for (const method of [ | ||
['createGzip', 'createGunzip', false], | ||
['createGzip', 'createUnzip', false], | ||
['createDeflate', 'createInflate', true], | ||
['createDeflateRaw', 'createInflateRaw', true] | ||
]) { | ||
let compWriter; | ||
let compData = new Buffer(0); | ||
|
||
const comp = zlib[method[0]](); | ||
comp.on('data', function(d) { | ||
compData = Buffer.concat([compData, d]); | ||
assert.strictEqual(this.bytesRead, compWriter.size, | ||
`Should get write size on ${method[0]} data.`); | ||
}); | ||
comp.on('end', common.mustCall(function() { | ||
assert.strictEqual(this.bytesRead, compWriter.size, | ||
`Should get write size on ${method[0]} end.`); | ||
assert.strictEqual(this.bytesRead, expectStr.length, | ||
`Should get data size on ${method[0]} end.`); | ||
|
||
{ | ||
let decompWriter; | ||
let decompData = new Buffer(0); | ||
|
||
const decomp = zlib[method[1]](); | ||
decomp.on('data', function(d) { | ||
decompData = Buffer.concat([decompData, d]); | ||
assert.strictEqual(this.bytesRead, decompWriter.size, | ||
`Should get write size on ${method[0]}/` + | ||
`${method[1]} data.`); | ||
}); | ||
decomp.on('end', common.mustCall(function() { | ||
assert.strictEqual(this.bytesRead, compData.length, | ||
`Should get compressed size on ${method[0]}/` + | ||
`${method[1]} end.`); | ||
assert.strictEqual(decompData.toString(), expectStr, | ||
`Should get original string on ${method[0]}/` + | ||
`${method[1]} end.`); | ||
})); | ||
decompWriter = createWriter(decomp, compData); | ||
} | ||
|
||
// Some methods should allow extra data after the compressed data | ||
if (method[2]) { | ||
const compDataExtra = Buffer.concat([compData, new Buffer('extra')]); | ||
|
||
let decompWriter; | ||
let decompData = new Buffer(0); | ||
|
||
const decomp = zlib[method[1]](); | ||
decomp.on('data', function(d) { | ||
decompData = Buffer.concat([decompData, d]); | ||
assert.strictEqual(this.bytesRead, decompWriter.size, | ||
`Should get write size on ${method[0]}/` + | ||
`${method[1]} data.`); | ||
}); | ||
decomp.on('end', common.mustCall(function() { | ||
assert.strictEqual(this.bytesRead, compData.length, | ||
`Should get compressed size on ${method[0]}/` + | ||
`${method[1]} end.`); | ||
assert.strictEqual(decompData.toString(), expectStr, | ||
`Should get original string on ${method[0]}/` + | ||
`${method[1]} end.`); | ||
})); | ||
decompWriter = createWriter(decomp, compDataExtra); | ||
} | ||
})); | ||
compWriter = createWriter(comp, expectBuf); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add
directly below this heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added