Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for vm's breakOnSigint option #12512

Closed
wants to merge 1 commit into from
Closed

test: add coverage for vm's breakOnSigint option #12512

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 19, 2017

The breakOnSigint option follows different code paths, depending on the number of listeners for SIGINT. This commit updates the existing test to vary the number of SIGINT handlers.

This should get code coverage on lib/vm.js to 100%.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig
test: add coverage for vm's breakOnSigint option
657a8f2 
The breakOnSigint option follows different code paths, depending
on the number of listeners for SIGINT. This commit updates the
existing test to vary the number of SIGINT handlers.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 19, 2017
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Apr 19, 2017
@DavidCai1111
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7546/

DavidCai1111 pushed a commit that referenced this pull request Apr 21, 2017
@cjihrig @DavidCai1111
test: add coverage for vm's breakOnSigint option
4bcbefc 
The breakOnSigint option follows different code paths, depending
on the number of listeners for SIGINT. This commit updates the
existing test to vary the number of SIGINT handlers.

PR-URL: #12512
Reviewed-By: David Cai <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@DavidCai1111
Copy link
Member

Landed in 4bcbefc

@cjihrig cjihrig deleted the vm branch April 21, 2017 14:16
@evanlucas
Copy link
Contributor

This is failing on v7.x-staging. Going to mark as don't land

@jasnell jasnell mentioned this pull request May 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @DavidCai1111 @evanlucas @jasnell @mscdex @addaleax @nodejs-github-bot