Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" #11652

bnoordhuis · 2017-03-02T12:27:11Z

See the commit log of the reverted commit: it's a semver-minor change
that can land in the next minor release.

This reverts commit 47cbb88.

CI: https://ci.nodejs.org/job/node-test-pull-request/6657/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/591/

mhdawson

LGTM

Fishrock123 · 2017-03-02T21:49:21Z

Is there related discussion context somewhere that is not linked to?

addaleax · 2017-03-02T23:24:52Z

@Fishrock123 Is #9293 (comment) what you are looking for?

bnoordhuis · 2017-03-03T09:06:52Z

@ofrobots From #9293 (comment):

It might be a good idea to add the a DCHECK in IsConstructCall to make sure that the equivalence relationship between is_construct_call_ & 1 and !NewTarget->IsUndefined holds.

I don't think I can do that. IsConstructCall() lives in v8.h, where DCHECK is not defined.

jasnell · 2017-03-22T17:43:31Z

Ping @bnoordhuis ... other than needing a rebase, is this ready to land?

bnoordhuis · 2017-03-23T11:29:18Z

Correct. Rebased although I don't understand why GH was showing a conflict, it applies cleanly.

jasnell · 2017-03-23T15:50:14Z

Yeah, I've also seen recently cases where github shows no conflicts for PRs that don't land cleanly. Not sure what's happening there.

New CI before landing: https://ci.nodejs.org/job/node-test-pull-request/7002/

jasnell · 2017-03-23T17:04:31Z

@bnoordhuis ... odd build failure on one of the linux boxes: https://ci.nodejs.org/job/node-test-commit-linux/8645/nodes=ubuntu1204-clang341-64/console

bnoordhuis · 2017-03-23T17:23:13Z

@nodejs/build Is that perhaps an artifact from upgrading the compiler toolchain recently? The file it's complaining about, deps/v8/src/base/functional.cc, hasn't been touched by this PR. In fact, it hasn't been touched since November 2014.

jasnell · 2017-03-23T17:24:29Z

Yeah, that's why it's odd ;) Im not really sure why that would fail all of a sudden.

Original Commit Message: PR-URL: nodejs#11872 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Backport-Of: nodejs#11872 PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#11670 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

These changes result in ~50% improvement in the included benchmark. PR-URL: nodejs#10580 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Backport-PR-URL: nodejs#11775 PR-URL: nodejs#10685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Manually fix issues that eslint --fix couldn't do automatically. Backport-PR-URL: nodejs#11775 PR-URL: nodejs#10685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: nodejs#12148 Ref: nodejs#6920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a process that is still starting up kills it with SIGKILL instead of SIGTERM. PR-URL: nodejs#12159 Refs: libuv/libuv#1226 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#12163 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: nodejs#12138 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: James M Snell <[email protected]>

look for the actual produced `exe` not just the directory PR-URL: nodejs#12120 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>

PR-URL: nodejs#11635 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

PR-URL: nodejs#12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

* Replace `var` by `const`. * Comment out ellipses. * Update code example (provide relevant file path, add missing option). PR-URL: nodejs#12171 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

I noticed that few of the print statements in configure have a leading space with is not consistent with the rest of the file. Not sure if this intentional or not so creating this commit just to bring it up just in case. PR-URL: nodejs#12176 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: mhdawson - Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Currently it is possible to configure using --without-ssl and --shared-openssl/--openssl-no-asm/openssl-fips without an error occuring. The commit add check for these combinations: $ ./configure --without-ssl --shared-openssl Error: --without-ssl is incompatible with --shared-openssl $ ./configure --without-ssl --openssl-no-asm Error: --without-ssl is incompatible with --openssl-no-asm $ ./configure --without-ssl --openssl-fips=dummy Error: --without-ssl is incompatible with --openssl-fips PR-URL: nodejs#12175 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Skip test-cluster-disconnect-handles on Windows. PR-URL: nodejs#12261 Ref: nodejs#12197 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

- a regular expression that matches the entire error message. PR-URL: nodejs#12139 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Prince John Wesley <[email protected]>

@aqrln

Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md PR-URL: nodejs#12273 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Can be cc'ed with `@nodejs/performance`. PR-URL: nodejs#12213 Refs: nodejs#12194 (comment) Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: nodejs#12247 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>

* Since nodejs#6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: nodejs#12262 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#12282 Fixes: nodejs#12280 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Where inclusion of a lengthy URL causes a line to exceed 80 characters in our code base, do not report the line length as a linting error. PR-URL: nodejs#11890 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: nodejs#12020 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>

PR-URL: nodejs#12277 Refs: https://github.com/nodejs/node/blob/master/doc/onboarding.md Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>

This commit adds lldbinit files from upstream V8 and also adds these so that they get installed when `make install` is run. Original commit message: [tools] add lldbinit The goal of this commit is to add the equivalent to gdbinit but for lldb. I've tried to replicate the commands as close as possible but I'm unsure about the jss command and hoping to get some feedback on it in addition to the bta command which I'm not sure how/when this could be used. This is probably just inexperience on my part. The lldbinit file can be placed into a directory prefixed with dot (.lldbinit) and the python script is currently expected to be in the same directory. The path to the script can be changed manually if needed as well. NOTRY=true Review-Url: https://codereview.chromium.org/2758373002 Cr-Commit-Position: refs/heads/master@{nodejs#44136} PR-URL: nodejs#12061 Reviewed-By: Ben Noordhuis <[email protected]>

See the commit log of the reverted commit: it's a semver-minor change that can land in the next minor release. This reverts commit 47cbb88.

bnoordhuis · 2017-04-19T08:46:50Z

Rebased, /cc @MylesBorins.

Node CI: https://ci.nodejs.org/job/node-test-pull-request/7509/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/657/

MylesBorins · 2017-05-16T01:40:28Z

landed in c6060fa

bnoordhuis added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 2, 2017

nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 2, 2017

addaleax approved these changes Mar 2, 2017

View reviewed changes

cjihrig approved these changes Mar 2, 2017

View reviewed changes

mhdawson approved these changes Mar 2, 2017

View reviewed changes

jasnell approved these changes Mar 2, 2017

View reviewed changes

bnoordhuis mentioned this pull request Mar 3, 2017

v8: fix new.target inheritance from c++ #9293

Merged

MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from b3f32f9 to e71fc70 Compare March 8, 2017 09:27

MylesBorins force-pushed the v6.x-staging branch from c2e818d to 426968d Compare March 21, 2017 21:27

bnoordhuis force-pushed the revert-47cbb88 branch from 6b8f3c7 to 1f0da51 Compare March 23, 2017 11:28

bnoordhuis mentioned this pull request Mar 23, 2017

deps: fix async await desugaring in V8 #12004

Merged

2 tasks

addaleax mentioned this pull request Mar 25, 2017

module: add support for abi stable module API #11975

Closed

4 tasks

mhdawson and others added 4 commits April 4, 2017 14:20

doc: add supported platforms list for v6.x

76e903e

PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

doc: fix broken URL to event loop guide

6486b97

PR-URL: nodejs#11670 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

MylesBorins force-pushed the v6.x-staging branch from 59b869e to 078188d Compare April 4, 2017 12:20

gibfahn and others added 2 commits April 13, 2017 15:11

tools, test: require const/let in test

daddf5a

Backport-PR-URL: nodejs#11775 PR-URL: nodejs#10685 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

silverwind and others added 22 commits April 18, 2017 19:25

test: increase querystring coverage

20c38eb

PR-URL: nodejs#12163 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

doc: add table of contents to README.md

90caad4

PR-URL: nodejs#11635 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

doc: fix string interpolation in Stream 'finish'

e9a6ddd

PR-URL: nodejs#12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

test: skip irrelevant test on Windows

6c4f786

Skip test-cluster-disconnect-handles on Windows. PR-URL: nodejs#12261 Ref: nodejs#12197 (comment) Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

doc: add aqrln to collaborators

72e011e

Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md PR-URL: nodejs#12273 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()"

4976e13

See the commit log of the reverted commit: it's a semver-minor change that can land in the next minor release. This reverts commit 47cbb88.

bnoordhuis force-pushed the revert-47cbb88 branch from 1f0da51 to 4976e13 Compare April 19, 2017 08:44

MylesBorins force-pushed the v6.x-staging branch from 404d1bc to 99dab5b Compare April 24, 2017 17:50

MylesBorins added the lts-agenda label Apr 24, 2017

MylesBorins force-pushed the v6.x-staging branch from f919807 to 87534d6 Compare May 2, 2017 18:01

MylesBorins closed this May 16, 2017

bnoordhuis mentioned this pull request Sep 29, 2017

node-addon-api fails to build against node 4.x nodejs/node-addon-api#142

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" #11652

Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" #11652

bnoordhuis commented Mar 2, 2017 •

edited

Loading

mhdawson left a comment

Fishrock123 commented Mar 2, 2017

addaleax commented Mar 2, 2017

bnoordhuis commented Mar 3, 2017

jasnell commented Mar 22, 2017

bnoordhuis commented Mar 23, 2017

jasnell commented Mar 23, 2017

jasnell commented Mar 23, 2017

bnoordhuis commented Mar 23, 2017

jasnell commented Mar 23, 2017

bnoordhuis commented Apr 19, 2017

MylesBorins commented May 16, 2017

Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" #11652

Revert "v8: drop v8::FunctionCallbackInfo<T>::NewTarget()" #11652

Conversation

bnoordhuis commented Mar 2, 2017 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

Fishrock123 commented Mar 2, 2017

addaleax commented Mar 2, 2017

bnoordhuis commented Mar 3, 2017

jasnell commented Mar 22, 2017

bnoordhuis commented Mar 23, 2017

jasnell commented Mar 23, 2017

jasnell commented Mar 23, 2017

bnoordhuis commented Mar 23, 2017

jasnell commented Mar 23, 2017

bnoordhuis commented Apr 19, 2017

MylesBorins commented May 16, 2017

bnoordhuis commented Mar 2, 2017 •

edited

Loading