Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: reduce test_inspector_socket_server output #10537

Closed
wants to merge 2 commits into from
Closed

src: reduce test_inspector_socket_server output #10537

wants to merge 2 commits into from

Commits on Dec 30, 2016

  1. src: reduce test_inspector_socket_server output 

    Currently, when test/cctest/test_inspector_socket_server.cc is run there
is output written to stderr by src/inspector_socket_server.cc which is
interleaved with the gtest report:

Debugger listening on port 9229.
Warning: This is an experimental feature and could change at any time.
To start debugging, open the following URLs in Chrome:
  ...

The goal of this commit is to remove the above logged information
by introducing an out_ member in the InspectorSocketServer class
which defaults to stderr (keeping the current behavior).

Setting out_ to NULL is supported in which case nothing will be written
and is what the test has been configured with. When working on specific
test case the appropriate output stream can be specified for the
ServerHolder constructor to limit logging to that test case.
    @danbev
    danbev committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    428345a View commit details
    Browse the repository at this point in the history

  2. fix indentation

    @danbev
    danbev committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    6467adf View commit details
    Browse the repository at this point in the history