Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate url module #9205

Closed
stevenvachon opened this issue Oct 20, 2016 · 10 comments
Closed

deprecate url module #9205

stevenvachon opened this issue Oct 20, 2016 · 10 comments

Comments

@stevenvachon
Copy link

in favour of a global.URL, which could be whatwg-url.

Obviously, this would be a major version thing (7.0?).

@evanlucas
Copy link
Contributor

I don't believe any more breaking changes can go into v7 at this point. The whatwg-url is also experimental.

@stevenvachon
Copy link
Author

I'm fine with this being an 8.0 thing. I'm more concerned with it being a thing.

@claudiorodriguez
Copy link
Contributor

claudiorodriguez commented Oct 20, 2016

Don't really like the global approach. Deprecating (if necessary) the url lib api in favour of what was introduced in #7448, maybe.

@stevenvachon
Copy link
Author

It uses more memory, I guess, but it simulates window.URL.

@jasnell
Copy link
Member

jasnell commented Oct 20, 2016

the new URL implementation is still experimental and will be through at least v8.0. The earliest we could consider deprecating url.parse() would be v9.0 and it would be much much longer before we could remove or replace it. The CTC decided against making the new URL class a global, which means that TC-39 would need to make it a global in the language in order for it to become a global in Node.js. Later on, once the implementation is no longer experimental, we could revisit that decision but for now, that's how it stands. The url module itself will not be deprecated at any point in the near future.

@stevenvachon
Copy link
Author

Ok. What is the CTC, by the way? Do you mean ECMA?

@jasnell
Copy link
Member

jasnell commented Oct 20, 2016

Sorry, CTC == Node.js Core Technical Committee.

@stevenvachon
Copy link
Author

Is there a URL global proposal? I don't see one at https://github.com/tc39/proposals

@jasnell
Copy link
Member

jasnell commented Oct 20, 2016

tc39/proposals#30

@stevenvachon
Copy link
Author

wtfux! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants