tools/release.sh failed on macOS 10.12 #8822
Labels
tools
Issues and PRs related to the tools directory.
Comments
1 task
evanlucas
added a commit
to evanlucas/node
that referenced
this issue
Oct 19, 2016
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: nodejs#8822
jasnell
pushed a commit
that referenced
this issue
Oct 20, 2016
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Nov 11, 2016
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Nov 11, 2016
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
after signing a tag for a release, the release script does some magic to sign the SHASUMS256.txt file.
It calls
git tag -v $version 2>&1 | grep 'key ID' | awk '{print $NF}'. (https://github.com/nodejs/node/blob/v6.7.0/tools/release.sh#L72)The output of that command does not return anything on my machine using git v2.10.0. If I use the builtin git provided by apple (git v2.8.4), then the script works properly.
Here are the outputs from
git tag -v v6.7.0:With git v2.10.0:
With git v2.8.4:
I am working on a proposed fix that works for both.
/cc @nodejs/release
The text was updated successfully, but these errors were encountered: