-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malformed crt with HTTPS SNI causes hang - no error, no result #867
Comments
Confirmed broken in
Confirmed working in
Perhaps there's an API change that I'm unaware of? If so it seems like this should throw an error, not just hang. |
Okay, so node.js / io.js latest have the flaw that although they don't work with a key file in the chain (good), they don't give an error or any indication of what went wrong. After removing the key file that was in the wrong place:
It works.
I can upload the exact certs that I'm using upon request. They're all test / dummy certs anyway, so no risk there. |
Hmm... my workaround didn't work on ARM, only on OS X. There's still something wrong... |
It only happens when I return the crts immediately (not using the optional callback) AND there's a malformed crt (aka a key) in the chain. If I use the callback or I take out the bad crt it works as expected (except I don't remember if using the callback sends an error or silently ignores the key). And it happens on OS X, but on Raspberry Pi returning immediately doesn't work at all anyway. I'd have to reinstall v1.2 or master to be certain, but I had a test case On v1.2 at the time I created the issue. |
@coolaj86 returning context is not supported anymore, I'm not sure how it could be working :) |
Maybe I had my node versions mixed up. Maybe I was actually on 0.11. In that case, sorry for the noise, I'll close this and the related issue and reopen if I can reconfirm. |
This just hangs without throwing an error or completing the request:
Expected result
client receives
server logs
Reduced Test Case
directory layout
The text was updated successfully, but these errors were encountered: