Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode.js issue #6143

Closed
KaiSchwarz-cnic opened this issue Apr 11, 2016 · 3 comments
Closed

punycode.js issue #6143

KaiSchwarz-cnic opened this issue Apr 11, 2016 · 3 comments
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. question Issues that look for answers. wontfix Issues that will not be fixed.

Comments

@KaiSchwarz-cnic
Copy link

In the domain business, just few TLDs are based on IDN 2008 punycode conversion:
.be, .ca, .de, .fr, .pm, .re, .swiss, .tf, .wf, .yt
All other TLDs use the IDN 2003 standard.

Just got that information from my team mates (we work in the domain business) and they point out that the npm module "idna-uts46" handles it in the right way. As punycode.js is bundled with node.js the better option IMO is to inform you instead of switching to another library.

Example:
fußbälle.de -> fussbälle.de (IDN 2003)
fußbälle.de -> fußbälle.de (IDN 2008) <-- the correct one!

fußbälle.org -> xn--fublle-cta5b.org -> fußbälle.org (which is wrong, has to be IDN 2003).
correct one would be: xn--fussblle-4za.org

this is still the case for punycode.js v1.3.2

@benjamingr
Copy link
Member

Ping @mathiasbynens

@mathiasbynens
Copy link
Contributor

Punycode.js implements Punycode and nothing more. IDNA / UTS 46 are separate things. See mathiasbynens/todo#9.

If you need UTS 46 support, use https://github.com/jcranmer/idna-uts46.

(For future reference: this was later filed as mathiasbynens/punycode.js#46.)

@Fishrock123 Fishrock123 added question Issues that look for answers. duplicate Issues and PRs that are duplicates of other issues or PRs. wontfix Issues that will not be fixed. labels Apr 11, 2016
@Fishrock123
Copy link
Contributor

Thanks for the quick response @mathiasbynens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. question Issues that look for answers. wontfix Issues that will not be fixed.
Projects
None yet
Development

No branches or pull requests

4 participants