Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test-path fails on Windows? #6119

Closed
jianchun opened this issue Apr 8, 2016 · 2 comments
Closed

test: test-path fails on Windows? #6119

jianchun opened this issue Apr 8, 2016 · 2 comments

Comments

@jianchun
Copy link

jianchun commented Apr 8, 2016

https://github.com/nodejs/node/blob/master/test/parallel/test-path.js#L564 has

assert.equal(path.win32._makeLong('C:').toLowerCase(),
                '\\\\?\\' + process.cwd().toLowerCase());

The former resolves to absolute path at C:: '\?\c:'.
The later resolves CWD, could be on another drive 'd:\dir'.

Seems only passes if CWD is at C:\?

@addaleax
Copy link
Member

addaleax commented Apr 8, 2016

This is being fixed in #6067 😄

@jianchun
Copy link
Author

jianchun commented Apr 8, 2016

@addaleax Thanks!

@jianchun jianchun closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants