Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs placeholder checks to lint-release-proposal workflow #56249

Closed
targos opened this issue Dec 13, 2024 · 1 comment
Closed

Add docs placeholder checks to lint-release-proposal workflow #56249

targos opened this issue Dec 13, 2024 · 1 comment

Comments

@targos
Copy link
Member

targos commented Dec 13, 2024

https://github.com/nodejs/node/blob/main/.github/workflows/lint-release-proposal.yml

So we don't find out later when the release build is triggered on Jenkins.

See

node/Makefile

Lines 1034 to 1044 in 6f084ff

@if [ "$(DISTTYPE)" = "release" ] && `grep -q REPLACEME doc/api/*.md`; then \
echo 'Please update REPLACEME tags in the following doc/api/*.md files (See doc/contributing/releases.md):\n' ; \
REPLACEMES="$(shell grep -l REPLACEME doc/api/*.md)" ; \
echo "$$REPLACEMES\n" | tr " " "\n" ; \
exit 1 ; \
fi
@if [ "$(DISTTYPE)" = "release" ] && \
`grep -q DEP...X doc/api/deprecations.md`; then \
echo 'Please update DEP...X in doc/api/deprecations.md (See doc/contributing/releases.md)' ; \
exit 1 ; \
fi

@targos
Copy link
Member Author

targos commented Dec 20, 2024

Assuming it was fixed by #56251

@targos targos closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant