Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint before tests on Windows #5514

Closed
Trott opened this issue Mar 1, 2016 · 3 comments
Closed

Run lint before tests on Windows #5514

Trott opened this issue Mar 1, 2016 · 3 comments
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Mar 1, 2016

Currently, running make test on UNIX-like operating systems will run the JS and C++ linting before running the tests. This is desirable because linting is fast and running the entire test suite is slow. If there are linting errors to fix, you want to find them and fix them before the tests run.

On Windows, however, the equivalent command in vcbuild.bat runs the tests before the lint tasks. It should be changed to run the lint tasks first.

@Trott Trott added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. labels Mar 1, 2016
@joaocgreis
Copy link
Member

Long time ago, I tried to port cpplint to vcbuild.bat, but never finished it. Here's what I had, needs work and testing, but might provide some inspiration if someone wants to move forward with it:

echo vcbuild.bat: Running cpplint
SETLOCAL enabledelayedexpansion
  for %%i in (src\*.cc src\*.h src\*.c tools\icu\*.h tools\icu\*.cc deps\debugger-agent\include\* deps\debugger-agent\src\*) do set CPPLINT_FILES=!CPPLINT_FILES! %%i
  set CPPLINT_FILES=%CPPLINT_FILES:src\node_root_certs.h=%
  set CPPLINT_FILES=%CPPLINT_FILES:src\node_win32_perfctr_provider.cc=%
  set CPPLINT_FILES=%CPPLINT_FILES:src\queue.h=%
  set CPPLINT_FILES=%CPPLINT_FILES:src\tree.h=%
  set CPPLINT_FILES=%CPPLINT_FILES:src\v8abbr.h=%
  python tools/cpplint.py %CPPLINT_FILES%
ENDLOCAL

@Trott
Copy link
Member Author

Trott commented Mar 14, 2016

Closing as this was reverted on the *nix side.

@Trott Trott closed this as completed Mar 14, 2016
@mithun-daa
Copy link
Contributor

I have a PR ready for this in the event it is decided that the linting be done before the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants