-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose file resolution as a utility #51855
Comments
IIUC, you mean a similar function to Said function would be used like: resolve("my_module", { conditions: ["default"], entryPoint: "..." }) Am I understanding correctly? |
Yes, assuming that your example's "entrypoint" means "resolve from the perspective of this file". |
@nodejs/loaders Hypothetically, could the Modules cache contain references to each import path condition so that the resolution could hop around the different conditions? |
We shouldn't cache what we don't use. For the purposes of this API the cache can be checked first but if it doesn't have what we need then we read from disk again. We shouldn't slow down the default case for someone potentially using this utility API. |
Okay, thanks. I was just wondering because if the |
There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the
never-stale
|
This issue is very much still relevant 🤔 Is this comment enough to remove the stale label? |
Is this not |
No, that is not the same thing. It doesn't let you choose the import conditions. |
Perhaps it could. The 2nd argument is already node-specific and conditions are very relevant to what it's doing, so I could see providing a 3rd config object argument. |
This would also help Jest resolve packages with subpath exports correctly. |
I create pull request for it lukeed/resolve.exports#37 |
This would also help us for our CSS bundler for those CSS authors who want to import a stylesheet from an npm package or other module. Currently we use |
What is the problem this feature will solve?
Tool authors often need to reimplement Node's resolving behaviors in order to ask the question: if this file was to import this path, which file would Node resolve that to?
This comes up for build tools like Vite, Esbuild, or Webpack. It also comes up for analysis tools like Eslint and Typescript.
For a long time, people were able to get by with the likes of https://www.npmjs.com/package/resolve. But the introduction of the full suite of package.json
exports
features (conditions, subpath imports, etc) and ESM have resulted in a situation where almost no tool actually covers Node's complete spec correctly anymore. It seems wasteful to try to fix all these parallel implementations rather than share node's implementation as a utility.What is the feature you are proposing to solve the problem?
A node-provided, importable constructor that takes conditions:
Where the
Resolver
instance offers a method with the signature:The key features provided here that are not provided (AFAIK) by any existing Node API are:
--conditions
that prevail in the current node process (remember -- we're talking about running this inside a tool like a linter. Regardless of what conditions the linter uses for its own implementation, it should follow imports the way the user's program is going to do it, using the user's conditions.)require.resolve
which, even if you setpaths
to the inside a package doesn't respect the self-referencing rule.Note that I'm definitely not asking for access to the state of the current node process's resolver. I don't want its customized loaders, I don't want to share its cache. Rather, this would be asking to set up an entirely separate state that would not interfere with Node's own module loading at all.
What alternatives have you considered?
There are lots of third-party implementations, maintained at great effort and all with incomplete support for Node's behaviors. In theory somebody could invest the effort to make one of them perfect and continually invest in making it follow new node features.
The text was updated successfully, but these errors were encountered: