Weird URL constructor behavior since 18.16.0

[JSMonk]

Version

from 18.16.0 to 21.6.1

Platform

Darwin NVC00566 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020 arm64

Subsystem

No response

What steps will reproduce the bug?

So, to see the behavior, we need to compare two versions of Node.js. Let's take 18.15.0 and any version from (and including) 18.16.0.

1. Open REPL
2. Put new URL("https://0.0.0.0x100/")
3. On 18.15.0 (and earlier versions), a TypeError: [ERR_INVALID_URL]: Invalid URL; on 18.16.0, the URL will be parsed as valid. Browsers such as Firefox v122 and Chrome v121.0.6167.85 also throw the error.

How often does it reproduce? Is there a required condition?

In 10 cases of 10

What is the expected behavior? Why is that the expected behavior?

The string should be accepted as an invalid URL, and the constructor should throw TypeError: [ERR_INVALID_URL]: Invalid URL

What do you see instead?

An URL object with 'https://0.0.1.0/ href

Additional information

No response

[richardlau]

cc @nodejs/url

[lemire]

Duplicate: #51514

Already fixed.

[lemire]

I recommend closing this issue. The fix is at #51542

[JSMonk]

@lemire, To which versions will this fix be backported?

[lemire]

@anonrig Please see @JSMonk's question.

[anonrig]

@lemire, To which versions will this fix be backported?

It will be backported to all release lines (18, 20 and 21)

[JSMonk]

@anonrig Has it been included in 21.6.2?

[anonrig]

@anonrig Has it been included in 21.6.2?

Afaict, it isn't included.