You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We were incorrectly parsing windows drive letters as schemes. This was
polluting the source map cache with malformed file paths.
Fixes: #50523
PR-URL: #50580
Reviewed-By: Chengzhong Wu <[email protected]>
We were incorrectly parsing windows drive letters as schemes. This was
polluting the source map cache with malformed file paths.
Fixes: #50523
PR-URL: #50580
Reviewed-By: Chengzhong Wu <[email protected]>
We were incorrectly parsing windows drive letters as schemes. This was
polluting the source map cache with malformed file paths.
Fixes: #50523
PR-URL: #50580
Reviewed-By: Chengzhong Wu <[email protected]>
Version
v20.9.0
Platform
Microsoft Windows NT 10.0.22635.0 x64
Subsystem
module
What steps will reproduce the bug?
git clone https://github.com/PaperStrike/node-c8-repro.git cd node-c8-repro npm ci
sources
like:--exclude-after-remap
option enabled.--exclude-after-remap
now works fine.How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
The generated source map
sources
field should contain absolute file URLs as the document stated.What do you see instead?
The generated source map cache contains a malformed path and breaks third-party tools.
Additional information
if (path.isAbsolute(source)) return url.pathToFileURL(source).href
prior to thereturn
innode/lib/internal/source_map/source_map_cache.js
Lines 254 to 258 in a1693c6
The text was updated successfully, but these errors were encountered: