-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readline documentation: event 'line' section wrongly restricts EOL to '\n' only #4916
Labels
good first issue
Issues that are suitable for first-time contributors.
readline
Issues and PRs related to the built-in readline module.
Comments
silverwind
added
the
readline
Issues and PRs related to the built-in readline module.
label
Jan 27, 2016
Looking at the code, it looks like it does check for all three cases. Care to make a docs PR? |
cjihrig
added
the
good first issue
Issues that are suitable for first-time contributors.
label
Jan 28, 2016
Sorry, my English and Github skills are not that good. |
rvagg
pushed a commit
that referenced
this issue
Jan 28, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: #4916 PR-URL: #4927 Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this issue
Feb 8, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: #4916 PR-URL: #4927 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Feb 17, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: #4916 PR-URL: #4927 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Feb 18, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: #4916 PR-URL: #4927 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Mar 2, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: #4916 PR-URL: #4927 Reviewed-By: Colin Ihrig <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this issue
Apr 2, 2016
This commit explicitly calls out the end of line sequences used to generate line events in the readline module. Fixes: nodejs#4916 PR-URL: nodejs#4927 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Issues that are suitable for first-time contributors.
readline
Issues and PRs related to the built-in readline module.
https://nodejs.org/api/readline.html#readline_event_line
I have tested this code with Windows 7 and Node 5.5.0 on three input files with Win-like EOL (\r\n), *nix-like EOL (\n) and old-Mac-like EOL (\r), and all the outputs were the same.
It seems readline correctly parses files with all the main EOLs.
The text was updated successfully, but these errors were encountered: