Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-runner: global after not working #48230

Closed
darky opened this issue May 28, 2023 · 0 comments · Fixed by #48231
Closed

test-runner: global after not working #48230

darky opened this issue May 28, 2023 · 0 comments · Fixed by #48231
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.

Comments

@darky
Copy link
Contributor

darky commented May 28, 2023

Version

20.2.0

Platform

Linux 6.3.3-arch1-1 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

node --test test.js

const { before, after, test } = require('node:test')

before(() => console.log('before'))
after(() => console.log('after'))

test('test', () => console.log('test'))

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

Expect printing after on stdout

What do you see instead?

Only see before and test printing on stdout

Additional information

No response

@MoLow MoLow changed the title test-runner: after not working test-runner: global after not working May 28, 2023
@MoLow MoLow added confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2023
nodejs-github-bot pushed a commit that referenced this issue May 31, 2023
PR-URL: #48231
Fixes: #48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this issue Jun 4, 2023
PR-URL: #48231
Fixes: #48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
franciszek-koltuniuk-red pushed a commit to franciszek-koltuniuk-red/node that referenced this issue Jun 7, 2023
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
PR-URL: #48231
Fixes: #48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Jul 6, 2023
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants