Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ESM loader changes to 18.x #48042

Closed
bencmbrook opened this issue May 16, 2023 · 7 comments
Closed

Backport ESM loader changes to 18.x #48042

bencmbrook opened this issue May 16, 2023 · 7 comments
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js. loaders Issues and PRs related to ES module loaders

Comments

@bencmbrook
Copy link

bencmbrook commented May 16, 2023

What is the problem this feature will solve?

Pulling this request (#43772 (comment)) into its own Issue.

This would allow chaining loaders in Node 18.x (and unlock many Yarn PnP use-cases without having to wait for 20.x LTS)

What is the feature you are proposing to solve the problem?

Backport the changes related to "ESM: Leverage loaders when resolving subsequent loaders".

What alternatives have you considered?

No response

@bencmbrook bencmbrook added the feature request Issues that request new features to be added to Node.js. label May 16, 2023
@VoltrexKeyva VoltrexKeyva added esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels May 17, 2023
@aduh95
Copy link
Contributor

aduh95 commented May 18, 2023

Did you check the backporting guide?

## What needs to be backported?
If a cherry-pick from `main` does not land cleanly on a staging branch, the
releaser will mark the pull request with a particular label for that release
line (e.g. `backport-requested-vN.x`), specifying to our tooling that this
pull request should not be included. The releaser will then add a comment
requesting that a backport pull request be made.
## What can be backported?
The "Current" release line is much more lenient than the LTS release lines in
what can be landed. Our LTS release lines (see the [Release Plan][])
require that commits mature in the Current release for at least 2 weeks before
they can be landed in an LTS staging branch. Only after "maturation" will those
commits be cherry-picked or backported.

TL;DR all commits that have landed on a current release branch will be backported "automatically" to the active LTS branches after a maturation period. If the commit doesn't land cleanly, the person preparing the release will add a comment to the PR asking for a manual backport.

v18.x is an active LTS release line at the time of writing, see the Release Schedule.

@aduh95 aduh95 closed this as completed May 18, 2023
@lizthegrey
Copy link

@aduh95 the PR in question had dont-land-on-v18.x previously, which may have broken the automation because it was previously skipped. it's now set to requested backport.

@bencmbrook
Copy link
Author

@aduh95 should this be reopened given the above comment from @lizthegrey ?

@lizthegrey
Copy link

This PR was not in fact backported via the usual automated means into Node 18.17.0 LTS last week. We request re-opening this issue since the automation has not backported it automatically. @aduh95 @MoLow @arcanis @bencmbrook

@aduh95
Copy link
Contributor

aduh95 commented Jul 20, 2023

To be clear, there are no automations in place, the process is very much manual: the volunteer for the LTS release will cherry-pick all the commits that have landed in v20.x – except the ones who do not land cleanly, and/or have a dont-land-on-v18.x or backport-requested-v18.x label on their associated PR.
I'm not sure I see the point of reopening this issue, it would be redundant with the backport-requested-v18.x label; what is needed here is someone to contribute a backport PR, and I'm doubtful that having an open issue will make that more likely.

@lizthegrey
Copy link

Oh! That clarifies a lot about how this PR got missed, and now that it's clear that contributing a backport PR is what's required, I can certainly have a go at it.

@lizthegrey
Copy link

490b598 Backport has now been landed, thx @arcanis and @targos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js. loaders Issues and PRs related to ES module loaders
Projects
None yet
Development

No branches or pull requests

4 participants