Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Node-API release checklist #47664

Closed
gabrielschulhof opened this issue Apr 22, 2023 · 1 comment · Fixed by #47972
Closed

Create a Node-API release checklist #47664

gabrielschulhof opened this issue Apr 22, 2023 · 1 comment · Fixed by #47972
Labels
feature request Issues that request new features to be added to Node.js. node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

What is the problem this feature will solve?

We need to make sure when we release a new version of Node-API we do not overlook any of the steps.

What is the feature you are proposing to solve the problem?

Let's add a document to the guides containing a list of steps necessary for creating a Node-API release PR.

What alternatives have you considered?

Looking at existing release commits to remember the steps. However, a new step will be added at https://github.com/nodejs/node/pull/45715/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bcR658 which previous releases will not reflect.
@gabrielschulhof gabrielschulhof added the feature request Issues that request new features to be added to Node.js. label Apr 22, 2023
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Apr 22, 2023
@gabrielschulhof gabrielschulhof mentioned this issue Apr 22, 2023
Closed
@mhdawson mhdawson mentioned this issue May 5, 2023
Closed
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented May 5, 2023 •
edited
Loading

With #45715 landed, the document must also mention that, as part of the release process, not only will new APIs in the headers have to be moved from NAPI_EXPERIMENTAL sections to NAPI_VERSION >= n sections, but, in the implementation files (node_api.cc and js_native_api_v8.cc), checks of the form if (env->module_api_version != NAPI_EXPERIMENTAL) have to be replaced with checks of the form if (env->module_api_version <= n).

@legendecas legendecas mentioned this issue May 12, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue May 19, 2023
@legendecas
doc: document node-api version process
1918241 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
fasenderos pushed a commit to fasenderos/node that referenced this issue May 22, 2023
@legendecas @fasenderos
doc: document node-api version process
5c401e3 
PR-URL: nodejs#47972
Fixes: nodejs#47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
targos pushed a commit that referenced this issue May 30, 2023
@legendecas @targos
doc: document node-api version process
0e4a3b7 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
@legendecas @danielleadams
doc: document node-api version process
d60c99a 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this issue Jul 6, 2023
@legendecas @MoLow
doc: document node-api version process
c22f739 
PR-URL: nodejs#47972
Fixes: nodejs#47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
@RedYetiDev RedYetiDev moved this from Awaiting Triage to Done in Node.js feature requests Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: document node-api version process legendecas/node
1 participant
@gabrielschulhof