riscv64: strange behavior of exception handling #47522
Comments
|
cc @luyahan |
VoltrexKeyva
added
the
riscv64
|
I'll leave the issue open for a few days so @luyahan can chime in but, as this is a bug in V8's riscv backend, Node's bug tracker isn't really the right place to report or discuss it. |
|
Hi! At least part of this issue, possibly the whole thing, was debugged by @WhatAmISupposedToPutHere and reported at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116057. It appears it wasn't an issue in the V8 backend for a specific platform, but rather a miscompilation by GCC of V8. It's still not completely clear whether there may be either UB or ill-advised code in V8, but GCC's fixed it on their side. As of writing, it's not yet been backported. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v19.8.1
Platform
Linux kxxt 6.2.10-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 07 Apr 2023 02:10:43 +0000 riscv64 GNU/Linux
Subsystem
No response
What steps will reproduce the bug?
pacman -S base-devel asp npm nodejsgit clone https://github.com/go-gitea/gitea -b release/v1.18 --depth=1 && cd giteanpm inpx lessc web_src/less/index.less outHow often does it reproduce? Is there a required condition?
100%. No condition is required.
What is the expected behavior? Why is that the expected behavior?
The generated css can be found in file
outandlesscexit with code 0.This is the behavior on x86_64 platform so it is the expected behavior.
What do you see instead?
Additional information
By adding some logging :
node_modules/less/lib/less/less-error.jsto show the stack trace.var LessError = function (e, fileContentMap, currentFilename) { Error.call(this); var filename = e.filename || currentFilename; this.message = e.message; this.stack = e.stack; if (fileContentMap && filename) { + console.log("Trace: ", e.stack);node_modules/less/lib/less/parser/parser.jsvar Parser = function Parser(context, imports, fileInfo) { ... function parseNode(str, parseList, currentIndex, fileInfo, callback) { var result; var returnNodes = []; var parser = parserInput; try { parser.start(str, false, function fail(msg, index) { callback({ message: msg, index: index + currentIndex }); }); for (var x = 0, p = void 0, i = void 0; (p = parseList[x]); x++) { i = parser.i; result = parsers[p](); if (result) { try { + console.log("The result is", result); result._index = i + currentIndex; result._fileInfo = fileInfo; + console.log("OK"); } catch (e) { + console.log("Caught exception", e); } returnNodes.push(result); } else { returnNodes.push(null); } } var endInfo = parser.end(); if (endInfo.isFinished) { callback(null, returnNodes); } else { callback(true, null); } } catch (e) { throw new less_error_1.default({ index: e.index + currentIndex, message: e.message }, imports, fileInfo.filename); } }We can get the following output:
Output
It seems that
catchinnode_modules/less/lib/less/parser/parser.jsdidn't catch the exception because there are no "Caught Exception" in the log._fileInfoon string"!important"seems to be successful because "OK" is logged.There are some failed jstest on riscv64 due to
Missing expected exception. Maybe it is caused by the same error.The nodejs build recipe used on arch riscv64
The nodejs-v8-jit-fix.patch is equivalient to #47399
This issue is also reproducible with JIT disabled:
NODE_OPTIONS=--jitless npx lessc web_src/less/index.less outThe text was updated successfully, but these errors were encountered: