Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readable data after close #39630

Closed
ronag opened this issue Aug 2, 2021 · 0 comments
Closed

Readable data after close #39630

ronag opened this issue Aug 2, 2021 · 0 comments
Labels
stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Aug 2, 2021 •
edited
Loading

Readable can emit data after error and close which contradicts the docs.
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Aug 2, 2021
ronag added a commit to nxtedition/node that referenced this issue Aug 3, 2021
@ronag
stream: don't emit 'data' after 'error' or 'close'
53dd60b 
As per doc we should not emit further events after 'close' and
only 'close' after 'error'.

Fixes: nodejs#39630
@ronag ronag mentioned this issue Aug 3, 2021
Closed
@ronag ronag closed this as completed in 0e841b4 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: don't emit 'data' after 'error' or 'close' nxtedition/node
1 participant
@ronag