-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible pipeline deadlock #39005
Comments
@mcollina I think we might need to change this to: await Promise.race([
await EE.once(writable, 'drain'),
EE.once(writable, 'close')
]) Which is a bit slow :/ |
ronag
added a commit
to nxtedition/node
that referenced
this issue
Jun 11, 2021
ronag
added a commit
to nxtedition/node
that referenced
this issue
Jun 11, 2021
jasnell
pushed a commit
that referenced
this issue
Jun 14, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jun 15, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jun 17, 2021
Refs: #39005 PR-URL: #39006 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From reviewing the code I notice the following:
https://github.com/nodejs/node/blob/master/lib/internal/streams/pipeline.js#L116
In particular the following:
writable
might never emit'drain'
or'error'
, instead only'close'
might be emitted. A bit unfortunate but that's how streams work.The text was updated successfully, but these errors were encountered: