Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 working group #3741

Closed
bnoordhuis opened this issue Nov 10, 2015 · 27 comments
Closed

V8 working group #3741

bnoordhuis opened this issue Nov 10, 2015 · 27 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@bnoordhuis
Copy link
Member

Proposal: put together a V8 WG.

Rationale:

  1. To have a side channel for V8 related work without spamming (or drowning in) the main bug tracker.
  2. To create documentation with best practices for contributing to V8 with the expectation that changes end up in node.js someday.
  3. To orchestrate V8 LTS work. Related: Option to run V8 test suite build#199

Optional:

  1. Shepherd patches submitted to nodejs/node. Many fall by the wayside now because contributing to upstream V8 is so onerous. Legalities TBD.

Background:

I picture it not as a WG in the traditional sense with a clearly defined charter and goals, but more as a self-help group where people can go if they want to work on V8 for whatever reason.

/cc @nodejs/ctc @nodejs/v8 @joransiu @mhdawson

@bnoordhuis bnoordhuis added tsc-agenda meta Issues and PRs related to the general management of the project. labels Nov 10, 2015
@evanlucas
Copy link
Contributor

I would be interested in being involved with this

@indutny
Copy link
Member

indutny commented Nov 10, 2015

Yes.

@joransiu
Copy link
Contributor

Me as well.

@thefourtheye
Copy link
Contributor

Me too, if it is okay.

@targos
Copy link
Member

targos commented Nov 10, 2015

+1

@Qard
Copy link
Member

Qard commented Nov 10, 2015

I'm also interested, albeit not certain how useful I'll be.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 10, 2015

I'm interested in learning more about the magical black box that is V8.

@ofrobots
Copy link
Contributor

👍

@trevnorris
Copy link
Contributor

Does this mean we would fork v8 into nodejs/v8 or such?

@jasnell
Copy link
Member

jasnell commented Nov 10, 2015

👍

@bnoordhuis
Copy link
Member Author

Does this mean we would fork v8 into nodejs/v8 or such?

If necessary. Details TBD.

@misterdjules
Copy link

One thing that I would like the project to avoid is to move the knowledge of V8 to a separate group. Having V8 issues/PRs discussed in the main repo has the benefit of exposing everyone who contributes to node.js' core to that part of the code base, and making everyone more aware of its problems/challenges.

I don't agree that the problems mentioned in the original proposal are currently actual problems:

  1. I don't find that V8 issues are spamming the issues tracker.
  2. The documentation can be written as any other documentation.
  3. Option to run V8 test suite build#199 can actually be a good opportunity for the build team to ramp up on getting to know V8 a bit more for those who are not familiar with it.

In other words I think that exposing more core contributors to V8 is better in the long term for the project, and I think that creating a separate group dedicated to it may achieve the opposite.

@Qard
Copy link
Member

Qard commented Nov 10, 2015

By the way, I started writing some introductory docs on node internals recently. I'd love to get some help on more in-depth documentation of our particular usage of V8.

I also created a tool to auto-generate V8 documentation for a specific commit of node. It needs a bit of clean-up though.

@paulfryzel
Copy link

I would be extremely interested in being involved with this group as well.

I currently maintain the official, unofficial V8 API master docs at: http://v8.paulfryzel.com/docs.

@bnoordhuis Do you think it may be useful to abstract this into a more general "Runtime WG" instead, or keep it specifically focused on the V8 engine? The reason I ask is because there have been previous threads around the use of other JS VM's (e.g. Chakra, JSC, or SpiderMonkey) within node and there are also a few other moving parts we use to process running JS (e.g. libuv) that (to the best of my knowledge) don't have a dedicated group.

@Qard
Copy link
Member

Qard commented Nov 10, 2015

@paulfryzel The runtime stuff seems to be a large part of the discussions of the API WG, so I think that sort of discussion can probably just live there.

@s3ththompson
Copy link

From the V8 perspective, it would be mildly easier to follow activity in a separate WG repo that via a label on the main repo, but I think this is of secondary concern to what is most productive for contributors and what exposes them to the most useful information.

r.e. "contributing to upstream V8 is so onerous", happy to field ideas about how to reduce the friction of this process.

@thefourtheye
Copy link
Contributor

happy to field ideas about how to reduce the friction of this process.

@s3ththompson Perhaps an installer which setups the environment for development. Also, the docs could be a little simpler.

@domenic
Copy link
Contributor

domenic commented Nov 11, 2015

There is such an installer: depot_tools

@mhdawson
Copy link
Member

+1 from me

@bnoordhuis
Copy link
Member Author

From today's CTC meeting: no objections, so moved. I'll work on setting up the preliminaries later this week and cc everyone that has expressed interest.

@misterdjules

The documentation can be written as any other documentation.

It's of similar scope as the LTS WG, where LTS-specific documentation lives in a separate repository. I'm perfectly happy with having it live in the main repo if it turns out it has wider appeal. Time will tell.

nodejs/build#199 can actually be a good opportunity for the build team to ramp up on getting to know V8 a bit more for those who are not familiar with it.

I'd be happy actually to leave it to the build WG. It's just an example of what a V8 WG could take on though.

@pmq20
Copy link
Contributor

pmq20 commented Nov 12, 2015

I'd be happy to be part of a V8 WG. I have at least one floating patch regarding V8 that I'd love to follow up: #2999

@john-yan
Copy link

count me in. :)

@bnoordhuis
Copy link
Member Author

Reopening. I haven't had time to set this up. If someone wants to take over, please say so. :-)

@bnoordhuis bnoordhuis reopened this Feb 20, 2016
@thefourtheye
Copy link
Contributor

I am still interested. So the @trevnorris 's question will be addressed by the WG?

Does this mean we would fork v8 into nodejs/v8 or such?

@bnoordhuis
Copy link
Member Author

Not 'fork' in the sense that it's a permanent, hard fork, more a place for collaborative work (discussion, development, code review) before sending it upstream. The work that @chrisdickinson is doing in chrisdickinson#2 isn't very visible now, for example.

@bmeck
Copy link
Member

bmeck commented Sep 6, 2016

@bnoordhuis is this still an effort?

@bnoordhuis
Copy link
Member Author

I guess this can be closed (again) - the current process seems to work okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests