Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Milad as a Node.js collaborator #36570

Closed
mhdawson opened this issue Dec 18, 2020 · 5 comments
Closed

Nominating Milad as a Node.js collaborator #36570

mhdawson opened this issue Dec 18, 2020 · 5 comments
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Comments

@mhdawson
Copy link
Member

I would like to nominate @miladfarca as a collaborator on the Node.js project. He's jumped into a lot of issues both on the V8 and nodejs front related to Power and s390 support and being a Node.js collaborator would make it easier for him to do this work.

Pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=author:miladfarca
Comments on pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=commenter:miladfarca
Reviews on pull requests in nodejs/node: https://github.com/nodejs/node/pulls?q=reviewed-by:miladfarca
Pull requests and issues opened throughout the Node.js organization: https://github.com/search?q=author:miladfarca+org:nodejs
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter:miladfarca+org:nodejs

@PoojaDurgad PoojaDurgad added the meta Issues and PRs related to the general management of the project. label Dec 21, 2020
@mhdawson
Copy link
Member Author

mhdawson commented Jan 6, 2021

As per the governance for collaborator nominations this is now approved.

@miladfarca can you confirm that you accept?

@mhdawson mhdawson added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Jan 6, 2021
@miladfarca
Copy link
Contributor

@mhdawson yes absolutely, thank you for nominating me.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 6, 2021

I'll set up a time for next week to do the onboarding. @Trott I think I saw in another thread that you try to attend when possible. Would like you me to give you an FYI on the time we set up?

@Trott
Copy link
Member

Trott commented Jan 15, 2021

I'll set up a time for next week to do the onboarding. @Trott I think I saw in another thread that you try to attend when possible. Would like you me to give you an FYI on the time we set up?

Oops, missed this. Uh, yes. But I guess I'm too late?

@mhdawson
Copy link
Member Author

@Trott sorry already done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

No branches or pull requests

4 participants