Node Inspector crash when launched via VS-Code

[KilianKilmister]

For more info check the Readme in the repo that caused the crash .The
repo is polished and ready to test on.

I don't know how much can be done as it involves a third party program, but i
still wanted to report it

General

• launched via VS-Code run task
  • both 'debug' and 'quick launch' cause a crash
• crash doesn't happen when launched via integrated terminal

VS-Code

• happens with all extensions disabled, too
• complete config and launch.json can be found in the .vscode folder

Crash-Log

Note: Using the "preview" debug extension
/usr/local/bin/node ./bin/ex.js
Debugger listening on ws://127.0.0.1:50032/9399bdea-1954-4adf-b249-1c4870f9d30f
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.

***I cut out everything from `console.log()` from my code***

bin/ex.js:112
Debugger listening on ws://127.0.0.1:50032/9399bdea-1954-4adf-b249-1c4870f9d30f
For help, see: https://nodejs.org/en/docs/inspector
undefined:0



illegal access
FATAL ERROR: 
node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
 1: 0x1012303e5 node::Abort() (.cold.1) [/usr/local/bin/node]
 2: 0x10009d2c9 node::Abort() [/usr/local/bin/node]
 3: 0x10009d42f node::OnFatalError(char const*, char const*) [/usr/local/bin/node]
 4: 0x10009d2d9 node::FatalError(char const*, char const*) [/usr/local/bin/node]
 5: 0x100164e33 node::inspector::Agent::ToggleAsyncHook(v8::Isolate*, v8::Global<v8::Function> const&) [/usr/local/bin/node]
 6: 0x100845d13 v8_inspector::V8Debugger::setAsyncCallStackDepth(v8_inspector::V8DebuggerAgentImpl*, int) [/usr/local/bin/node]
 7: 0x10084d2c3 v8_inspector::V8DebuggerAgentImpl::disable() [/usr/local/bin/node]
 8: 0x1008641f4 v8_inspector::V8InspectorSessionImpl::~V8InspectorSessionImpl() [/usr/local/bin/node]
 9: 0x1008644ae v8_inspector::V8InspectorSessionImpl::~V8InspectorSessionImpl() [/usr/local/bin/node]
10: 0x100165c9b node::inspector::(anonymous namespace)::ChannelImpl::~ChannelImpl() [/usr/local/bin/node]
11: 0x100165d0e node::inspector::(anonymous namespace)::ChannelImpl::~ChannelImpl() [/usr/local/bin/node]
12: 0x1001665ce node::inspector::NodeInspectorClient::disconnectFrontend(int) [/usr/local/bin/node]
13: 0x10016633b node::inspector::(anonymous namespace)::SameThreadInspectorSession::~SameThreadInspectorSession() [/usr/local/bin/node]
14: 0x1001790bc node::inspector::(anonymous namespace)::DeletableWrapper<node::inspector::(anonymous namespace)::MainThreadSessionState>::~DeletableWrapper() [/usr/local/bin/node]
15: 0x10015805a unsigned long std::__1::__hash_table<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::__unordered_map_hasher<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::hash<int>, true>, std::__1::__unordered_map_equal<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::equal_to<int>, true>, std::__1::allocator<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > > > >::__erase_unique<int>(int const&) [/usr/local/bin/node]
16: 0x1001792ae node::inspector::(anonymous namespace)::DeleteRequest::Call(node::inspector::MainThreadInterface*) [/usr/local/bin/node]
17: 0x100177f2d node::inspector::MainThreadInterface::DispatchMessages() [/usr/local/bin/node]
Process exited with code null

Tree of the involved files and ENV can be found in the repo

[jkrems]

(Moving to node from node-inspect since this seems to be using the raw --inspect flag, not the CLI debugger.)

[jkrems]

Ping @nodejs/inspector @nodejs/diagnostics

[jkrems]

@KilianKilmister Thanks for the great report with repo and everything! From the repo README I assume you were using macOS?

Can you share the version of node as well, just in case it's specific to one specific build?

[KilianKilmister]

@jkrems I was in need of a break anyways so i was quite glad I could do something else for a bit. I don't mind preparing reports and things like that. I see it as just another way of contributing, so i might aswell invest some energy to help improve something i use on a daly basis.

Completly forgot about adding nodeV and OS, thinking about it: wouldn't it be a good idea to include those things in the in the debugger init message?

anyways, it's been a while so i'm nut 100% sure.

• nodeV was either 13.0.0 or 13.14.0
• running on macOS CatalinaV 10.15ish
• It would have been smart to add the VS-code version, too. I'm using code-insiders. Version was probably the then latest nightly

I believe the culprid was a botched downgrade from the then v14 latest i had to do for some dependency throwing a fit about v14.
I did a clean install and haven't had this issue since. really weird how that seemed to only affected the VS-code debugger.
But that probably means that there is not much of a point in persuing this much further.

Thanks anyways. at least now i know that my effort of preparing the repo was appreciated. So I'll be doing the same when I encounter another notable crash.

[joyeecheung]

This might be a duplicate of #27261

[jkrems]

Thanks, that does look like the same error! Marking this as a duplicate for now since it seems likely.

Duplicate of #27261