-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'worker_threads.receiveMessageOnPort' results in an abort #32742
Labels
Comments
addaleax
added
confirmed-bug
Issues with confirmed bugs.
worker
Issues and PRs related to Worker support.
labels
Apr 9, 2020
addaleax
added a commit
to addaleax/node
that referenced
this issue
Apr 9, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: nodejs#32742
3 tasks
BethGriggs
pushed a commit
that referenced
this issue
Apr 14, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this issue
Apr 25, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: nodejs#32742 PR-URL: nodejs#32745 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
BridgeAR
pushed a commit
that referenced
this issue
Apr 28, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
targos
pushed a commit
that referenced
this issue
Apr 28, 2020
Use the same type check we use in `MoveToContext()` in `ReceiveMessage()`. Fixes: #32742 PR-URL: #32745 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What steps will reproduce the bug?
Directly run the following code snippet using node:
How often does it reproduce? Is there a required condition?
No. This potential bug can always be reproduced.
What is the expected behavior?
The argument to 'worker_threads.receiveMessageOnPort' should be a 'MessagePort' object, but we passed an integer value into it. The function should throw an exception or other similar error-reporting stuff rather than crash the whole nodejs process.
What do you see instead?
This is the stack dump produced during abort:
Additional information
The text was updated successfully, but these errors were encountered: