Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building of node.js 0.12.7 fails on commit 9116b240c924d37627313416b7ee038d0580afbc #2899

Closed
Junkern opened this issue Sep 16, 2015 · 3 comments
Labels
question Issues that look for answers.

Comments

@Junkern
Copy link

Junkern commented Sep 16, 2015

I am currently trying to build node v0.12.7 on commit 9116b24 (where v8 got updated to 3.28.73). Please do not ask why I have to build node on that specific commit ;)

Error message is: /home/vagrant/nodev0.12.7/node/out/Release/obj/gen/debug-support.cc:6:16: fatal error: v8.h: No such file or directory #include "v8.h"

I am building on ubuntu 14.04, prerequisites are installed.
Any help is appreciated!

@mscdex mscdex added the question Issues that look for answers. label Sep 16, 2015
@Fishrock123
Copy link
Contributor

Looking at https://github.com/nodejs/node/commits/v0.12?page=14 you'll probably have to build on at least 685ac09.

V8 upgrades have not always been (and sometimes still aren't) self-contained. Let us know if that works.

@Junkern
Copy link
Author

Junkern commented Sep 17, 2015

That works, thanks alot!
Is there any clear sign to know whether v8 upgrades are self-contained or not?
Just one more question: What exactly is the difference between the v0.12 and the 0.12.7 branch?

@Fishrock123
Copy link
Contributor

V8 upgrades nowadays are easier to tell. Usually you just make sure you grab all the v8: commits. Generally, you're always safe if you build from a tag.

v0.12 is the dev branch for 0.12. The next release cut off of it will be 0.12.8. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

3 participants