Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: experimental napi_add_finalizer documented as stable api #24509

Closed
legendecas opened this issue Nov 20, 2018 · 4 comments
Closed

n-api: experimental napi_add_finalizer documented as stable api #24509

legendecas opened this issue Nov 20, 2018 · 4 comments
Assignees

Comments

@legendecas
Copy link
Member

  • Version: 10.13.0
  • Platform: all
  • Subsystem: n-api

napi_add_finalizer is declared as experimental in node_api.h(here), yet it does not been documented as experimental in document.

@legendecas
Copy link
Member Author

/cc @gabrielschulhof @mhdawson

@mhdawson
Copy link
Member

@legendecas thanks I'll make sure to update that.

@mhdawson mhdawson assigned mhdawson and unassigned mhdawson Nov 22, 2018
mhdawson added a commit to mhdawson/io.js that referenced this issue Nov 22, 2018
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
@mhdawson
Copy link
Member

PR here #24572

Trott pushed a commit to Trott/io.js that referenced this issue Nov 24, 2018
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Closed by ce890a0

@Trott Trott closed this as completed Nov 24, 2018
targos pushed a commit that referenced this issue Nov 24, 2018
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this issue Nov 28, 2018
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: nodejs#24509
PR-URL: nodejs#24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 11, 2019
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
This was missed when the function was added. As it
is experimental in the code it should also be
experimental in the docs.

Fixes: #24509
PR-URL: #24572
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants