Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a single test using --expose-internals throws an error [nodeconf code and learn] #24193

Closed
luisfarzati opened this issue Nov 6, 2018 · 2 comments · Fixed by #24204
Closed
Labels
confirmed-bug Issues with confirmed bugs. test Issues and PRs related to the tests.

Comments

@luisfarzati
Copy link

  • Version: current
  • Platform: macOS
  • Subsystem: internal

Steps followed:

  • built node by following the instructions here
  • ran single test test/parallel/test-internal-errors.js by following the instructions here and got the error shown below
$ ./node --expose-internals ./test/parallel/test-internal-errors.js
/Users/lufo/w/nodeconfeu/codenlearn/node/test/common/index.js:585
        throw new assert.AssertionError({
        ^

AssertionError [ERR_ASSERTION]: Expected "actual" to be reference-equal to "expected":
+ actual - expected

  Comparison {
    code: 'ERR_ASSERTION',
+   message: `Expected "actual" to be reference-equal to "expected":\n\u001b[32m+ actual\u001b[39m \u001b[31m- expected\u001b[39m\n\n  Comparison {\n    code: 'TEST_ERROR_1',\n\u001b[32m+\u001b[39m   type: [Function: TypeError]\n\u001b[31m-\u001b[39m   type: [Function: RangeError]\n  }`
-   message: /\+   type: \[Function: TypeError]\n-   type: \[Function: RangeError]/
  }
    at new AssertionError (internal/assert.js:394:11)
    at Object.innerFn (/Users/lufo/w/nodeconfeu/codenlearn/node/test/common/index.js:585:15)
    at expectedException (assert.js:568:19)
    at expectsError (assert.js:663:16)
    at Function.throws (assert.js:694:3)
    at Object.expectsError (/Users/lufo/w/nodeconfeu/codenlearn/node/test/common/index.js:597:12)
    at Object.<anonymous> (/Users/lufo/w/nodeconfeu/codenlearn/node/test/parallel/test-internal-errors.js:79:8)
    at Module._compile (internal/modules/cjs/loader.js:722:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:733:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)

I don't get this error when tests are run with the following command:

$ python tools/test.py -J --mode=release parallel/test-internal-errors
[00:00|% 100|+   1|-   0]: Done
@bnoordhuis bnoordhuis added confirmed-bug Issues with confirmed bugs. test Issues and PRs related to the tests. labels Nov 6, 2018
@bnoordhuis
Copy link
Member

$ env NODE_DISABLE_COLORS=1 ./out/Release/node --expose-internals test/parallel/test-internal-errors.js
Error [ERR_TLS_HANDSHAKE_TIMEOUT]: TLS handshake timeout
    at Object.<anonymous> (/Users/bnoordhuis/src/v1.x/test/parallel/test-internal-errors.js:250:19)
    at Module._compile (internal/modules/cjs/loader.js:707:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
    at Module.load (internal/modules/cjs/loader.js:605:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
    at Function.Module._load (internal/modules/cjs/loader.js:536:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:760:12)
    at startup (internal/bootstrap/node.js:308:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:878:3)
Error [ERR_TLS_HANDSHAKE_TIMEOUT]: TLS handshake timeout
    at Object.<anonymous> (/Users/bnoordhuis/src/v1.x/test/parallel/test-internal-errors.js:250:19)
    at Module._compile (internal/modules/cjs/loader.js:707:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:718:10)
    at Module.load (internal/modules/cjs/loader.js:605:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:544:12)
    at Function.Module._load (internal/modules/cjs/loader.js:536:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:760:12)
    at startup (internal/bootstrap/node.js:308:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:878:3)
(node:11881) internal/test/binding: These APIs are exposed only for testing and are not tracked by any versioning system or deprecation process.
$ echo $?
0

IOW, the coloring throws it off.

@refack
Copy link
Contributor

refack commented Nov 6, 2018

Proposed (very local) fix #24204
Refs: #19723

refack added a commit to refack/node that referenced this issue Nov 7, 2018
BridgeAR pushed a commit that referenced this issue Nov 14, 2018
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this issue Nov 15, 2018
codebytere pushed a commit that referenced this issue Nov 29, 2018
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 29, 2018
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 3, 2018
PR-URL: #24204
Fixes: #24193
Refs: #19723
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants