-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAssembly global is not mentioned in documentation #23334
Comments
I think listing it in globals.md is good for now. We should likely have a dedicated page in the docs for it eventually tho. |
@nodejs/documentation |
we should just link to the mdn docs for it from globals.md |
@devsnek Is the API 100% compatible? What about the streaming APIs such as |
This is perhaps good-first-contribution worthy? |
@styfle assuming we were to enable streaming compilation it would work. node and chrome use the same implementation from V8. |
@devsnek From a quick test (and from the sound of your comment) the streaming compilation is not ready so the docs should make this clear. If/when that feature is enabled, then it can be added to the docs and the version can reflect when that shipped. Speaking of which, at what version was the WebAssembly global added? |
@styfle A quick test suggests it was 8.0.0. $ node -v
v7.10.1
$ node -p 'typeof WebAssembly'
undefined
$ nvm use 8.0.0
Now using node v8.0.0 (npm v5.0.2)
$ node -p 'typeof WebAssembly'
object
$ |
@Trott Nice! That matches the MDN compatibility table. I will create a PR to get this added to the globals and probably include a link to the MDN docs 👍 |
I created PR #23339 |
It looks like the
WebAssembly
global is available but there is no mention in the docs of when this was introduced and which features are available.Example usage: https://glot.io/snippets/f5j3smuum8
Should WebAssembly be added to the globals page or maybe even add a separate page?
The text was updated successfully, but these errors were encountered: