OpenBSD bad node executable.

[sylkat]

• Version:8.11.4(LTS)
• Platform:OpenBSD 6.3 GENERIC#100 amd64
• Subsystem:lib/internal/bootstrap_node.js

The node executable generated by gmake gives this error:

bootstrap_node.js:78
      process.execPath = realpathSync.native(process.execPath);                                    
TypeError: realpathSync.native is not a function
    at startup (bootstrap_node.js:78:39)
    at bootstrap_node.js:612:3

The error is in bootstrap_node.js line 78:

// On OpenBSD process.execPath will be relative unless we
// get the full path before process.execPath is used.
   if (process.platform === 'openbsd') {
     const { realpathSync } = NativeModule.require('fs');
     **process.execPath = realpathSync.native(process.execPath);**
   }

This code is executed only for OpenBSD and commenting it will generate a correct node executable.
So the patch is comment those lines, maybe for older versions were need is not the case and the FS module seems that has not the native method anymore.

Regards,
Sylkat

[addaleax]

This might have been caused by backporting #18543 to release branches where realpathSync.native is not available – what happens when you remove .native? I think that should work (and if it does, feel free to open a pull request with that against the v8.x-staging branch).

[sylkat]

Yes just removing the .native is working.

[addaleax]

@sylkat Okay, great – do you want to open a PR or should I?

[sylkat]

Well really is the first time i am doing a pull in git and just now i am the guidelines for how to do it.
Sorry i didn't contribute to git, first time i do..so will take a little to do it, i guess i have to generate a patch and so..
Is ok if takes few hours?

[sylkat]

Well i dont think is that complex i just generate the patch and post it with a little explanation.

[addaleax]

@sylkat It’s perfectly fine for things to take a while, yes. And you’re right, the change itself is simple, so it’s perfectly fine if you’d prefer to not do it. If you need any help, feel free to ping me here or on IRC (https://webchat.freenode.net/?channels=node-dev&uio=d4).

(If you do post a patch, make sure to include the name/email address with which you want to be listed in the changelog somewhere.)

[sylkat]

I posted the pull request:
#22632
If i have to edit it or you see something wrong feel free to tell me :)

[sylkat]

I forked , commited the fix and pull request to merge from my fork to the v8.x-staging.
Hope this time is ok ;)

#22663

[apapirovski]

This was fixed.