Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-module-loading-globalpaths with --worker on #22228

Closed
joyeecheung opened this issue Aug 10, 2018 · 3 comments
Closed

Investigate flaky test-module-loading-globalpaths with --worker on #22228

joyeecheung opened this issue Aug 10, 2018 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.

Comments

@joyeecheung
Copy link
Member

Reason: parallel/test-module-loading-globalpaths
Type: JS_TEST_FAILURE
Failed PR: 5 (#21857, #22209, #22020, #22152, #22212)
Appeared: test-packetnet-ubuntu1604-x64-2

In the latest 100 CI runs:
First CI: https://ci.nodejs.org/job/node-test-pull-request/16260/
Last CI: https://ci.nodejs.org/job/node-test-pull-request/16304/

All appeared in node-test-commit-custom-suites (with --worker on)

Example:

URL        https://ci.nodejs.org/job/node-test-commit-custom-suites/default/581/console
Type       JS_TEST_FAILURE
Built On   test-packetnet-ubuntu1604-x64-2
Reason
  not ok 1267 parallel/test-module-loading-globalpaths
    ---
    duration_ms: 34.654
    severity: fail
    exitcode: 1
    stack: |-
      internal/modules/cjs/loader.js:583
          throw err;
          ^

      Error: Cannot find module 'foo'
          at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
          at Function.Module._load (internal/modules/cjs/loader.js:507:25)
          at Module.require (internal/modules/cjs/loader.js:637:17)
          at require (internal/modules/cjs/helpers.js:20:18)
          at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites@3/default/test/parallel/test-module-loading-globalpaths.js:15:15)
          at Module._compile (internal/modules/cjs/loader.js:689:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
          at Module.load (internal/modules/cjs/loader.js:599:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
          at Function.Module._load (internal/modules/cjs/loader.js:530:3)
      events.js:173
          throw err; // Unhandled 'error' event
          ^

      Error [ERR_UNHANDLED_ERROR]: Unhandled error. ({ Error: spawnSync /home/iojs/node-tmp/.tmp.1/install/bin/node ENOENT
          at Object.spawnSync (internal/child_process.js:982:20)
          at spawnSync (child_process.js:587:24)
          at Object.execFileSync (child_process.js:615:13)
          at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites@3/default/test/parallel/test-module-loading-globalpaths.js:100:31)
          at Module._compile (internal/modules/cjs/loader.js:689:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
          at Module.load (internal/modules/cjs/loader.js:599:32)
          at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
          at Function.Module._load (internal/modules/cjs/loader.js:530:3)
          at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
        errno: 'ENOENT',
        code: 'ENOENT',
        syscall: 'spawnSync /home/iojs/node-tmp/.tmp.1/install/bin/node',
        path: '/home/iojs/node-tmp/.tmp.1/install/bin/node',
        spawnargs:
         [ '/home/iojs/build/workspace/node-test-commit-custom-suites@3/default/test/fixtures/test-module-loading-globalpaths/local-pkg/test.js' ],
        error: [Circular],
        status: null,
        signal: null,
        output: null,
        pid: 4777,
        stdout: null,
        stderr: null })
          at Worker.emit (events.js:171:17)
          at Worker.[kOnErrorMessage] (internal/worker.js:296:10)
          at Worker.[kOnMessage] (internal/worker.js:306:37)
          at MessagePort.Worker.(anonymous function).on (internal/worker.js:243:57)
          at MessagePort.emit (events.js:182:13)
          at MessagePort.onmessage (internal/worker.js:66:8)
    ...

@maclover7 maclover7 changed the title Investigate flaky test-module-loading-globalpaths in node-test-commit-custom-suites Investigate flaky test-module-loading-globalpaths with --worker on Aug 10, 2018
@maclover7 maclover7 added module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Aug 10, 2018
@maclover7
Copy link
Contributor

(edited the title to include the bit about --worker)

cc @addaleax

@addaleax
Copy link
Member

addaleax commented Sep 9, 2018

Is this still happening? I didn’t manage to reproduce it so far :/

@Trott
Copy link
Member

Trott commented Nov 26, 2018

Unable to find this in the last 100 PR CI runs. Feel free to re-open if I'm wrong to close this, but given the length of time since it's been reported and the lack of activity and reproducibility, it seems like the right thing to do.

@Trott Trott closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Development

No branches or pull requests

4 participants