Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborator nomination - gdams #21934

Closed
mhdawson opened this issue Jul 22, 2018 · 15 comments
Closed

Collaborator nomination - gdams #21934

mhdawson opened this issue Jul 22, 2018 · 15 comments
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Comments

@mhdawson
Copy link
Member

I'd like to nominate George Adams as a collaborator.

He has been active in the CiTGM, Build and core repos over the last year.

PRs in Node core
Comments on Issues and PRs in Node core
PRs in Build WG
Comments on Issues and PRs in Build WG
PRs in CitGM repo
Comments on Issues and PRs in CitGM repo

@mhdawson
Copy link
Member Author

@nodejs/collaborators

@devsnek
Copy link
Member

devsnek commented Jul 22, 2018

just for clarity, @ChALkeR, @addaleax, @richardlau, @targos, @thefourtheye and @benjamingr have thumbed-up

(for the future, please comment instead of reacting)

@devsnek
Copy link
Member

devsnek commented Jul 22, 2018

+1

@devsnek devsnek added meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Jul 22, 2018
@addaleax
Copy link
Member

@devsnek Is there any particular reason you prefer commenting/is this documented somewhere?

@devsnek
Copy link
Member

devsnek commented Jul 22, 2018

@addaleax after enough people react you have to use the api to see the full list

edit: i'm not trying to say you shouldn't react, just make sure if you want to be explicit that you also comment.

@benjamingr
Copy link
Member

@devsnek it is unfortunate that it is impossible to +1 without pinging people - I'm also not aware of the process around the +1s at all like Anna. I just thought we were being kind to the nominee and showing we acknowledge their contribution and are 👍 on adding them.

In any case - +1

@ryzokuken
Copy link
Contributor

+1

1 similar comment
@mcollina
Copy link
Member

+1

@ChALkeR
Copy link
Member

ChALkeR commented Jul 22, 2018

Ok, to be explicit: +1

@gireeshpunathil
Copy link
Member

+1

@richardlau
Copy link
Member

(for the future, please comment instead of reacting)

I'm not against people commenting if they want to explicitly endorse a collaborator nomination, but my person opinion is that a +1 post on its own is just noise, especially since the process around nominations is based on there not being any objections and is not a vote (i.e. the +1's don't influence the outcome of the process):

If there are no objections raised by any Collaborators one week after the issue is opened, the nomination will be considered as accepted. Should there be any objections against the nomination, the TSC is responsible for working with the individuals involved and finding a resolution. The nomination must be approved by the TSC, which is assumed when there are no objections from any TSC members.

https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborator-nominations

But in any case since I am commenting +1 from me (with a disclaimer that I work in the same office/team as @gdams at IBM).

@cjihrig
Copy link
Contributor

cjihrig commented Jul 22, 2018

+1

@trivikr
Copy link
Member

trivikr commented Jul 24, 2018

+1

@gdams
Copy link
Member

gdams commented Jul 27, 2018

Thanks for the nomination @mhdawson! 🎉

@richardlau
Copy link
Member

This happened in #22236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

No branches or pull requests