-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collaborator nomination - gdams #21934
Comments
@nodejs/collaborators |
just for clarity, @ChALkeR, @addaleax, @richardlau, @targos, @thefourtheye and @benjamingr have thumbed-up (for the future, please comment instead of reacting) |
+1 |
@devsnek Is there any particular reason you prefer commenting/is this documented somewhere? |
@addaleax after enough people react you have to use the api to see the full list edit: i'm not trying to say you shouldn't react, just make sure if you want to be explicit that you also comment. |
@devsnek it is unfortunate that it is impossible to +1 without pinging people - I'm also not aware of the process around the +1s at all like Anna. I just thought we were being kind to the nominee and showing we acknowledge their contribution and are 👍 on adding them. In any case - +1 |
+1 |
1 similar comment
+1 |
Ok, to be explicit: +1 |
+1 |
I'm not against people commenting if they want to explicitly endorse a collaborator nomination, but my person opinion is that a
https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborator-nominations But in any case since I am commenting +1 from me (with a disclaimer that I work in the same office/team as @gdams at IBM). |
+1 |
+1 |
Thanks for the nomination @mhdawson! 🎉 |
This happened in #22236. |
I'd like to nominate George Adams as a collaborator.
He has been active in the CiTGM, Build and core repos over the last year.
PRs in Node core
Comments on Issues and PRs in Node core
PRs in Build WG
Comments on Issues and PRs in Build WG
PRs in CitGM repo
Comments on Issues and PRs in CitGM repo
The text was updated successfully, but these errors were encountered: