Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: clang version is misdetected for double-digit clang versions #21175

Closed
mistydemeo opened this issue Jun 6, 2018 · 3 comments
Closed
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.

Comments

@mistydemeo
Copy link
Contributor

mistydemeo commented Jun 6, 2018

  • Version: v10.3.0
  • Platform:
  • Subsystem:

Configure performs a check to see if clang is newer than 3.4.2. However, this check is done against the string parsed out of the clang output in try_check_compiler: https://github.com/nodejs/node/blob/master/configure#L710 This results in miscomparisons for double-digit clang versions. For example, if clang_version is '10.0.0', then clang_version < '3.4.2' is false even though clang 10 is definitely newer than 3.

@Trott
Copy link
Member

Trott commented Jun 6, 2018

Thanks! #21173 should fix this.

@Trott Trott added confirmed-bug Issues with confirmed bugs. build Issues and PRs related to build files or the CI. labels Jun 6, 2018
@mistydemeo
Copy link
Contributor Author

Thanks! Works for me, though it left a spurious "compiler is too old" warning; I fixed that in #21183.

@addaleax
Copy link
Member

I think this can be closed? Let us know if I’m mistaken. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants