Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to release procedure: tag after build #1969

Closed
rvagg opened this issue Jun 13, 2015 · 3 comments
Closed

Change to release procedure: tag after build #1969

rvagg opened this issue Jun 13, 2015 · 3 comments
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Jun 13, 2015

This is for @nodejs/build and also @chrisdickinson and @Fishrock123

During our last build convergence meeting @misterdjules mentioned that he tags after building releases for joyent/node. We currently tag before release as we use the tag name for the Jenkins build to both fetch the right commit and name the builds. Unfortunately on a few occasions we've had failed builds but because they were already tagged we had to bump the patch version after fixing and then build again. Ideally, the releaser should be able to push an arbitrary branch, run the build by specifying a commit, then if they decide that should be promoted as as a release version then they merge & tag at the same time as promoting.

This will require minor changes to our Jenkins setup and also some work similar to #1938 to make the Makefile and vcbuild.bat a little smarter (I think).

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Jun 13, 2015
@brendanashworth brendanashworth added the build Issues and PRs related to build files or the CI. label Jun 13, 2015
@chrisdickinson
Copy link
Contributor

This would be awesome. Tagging after build would alleviate a lot of the stress I felt during the botched v1.8.0 release.

@Fishrock123
Copy link
Contributor

👍

@Fishrock123
Copy link
Contributor

This was done at some point. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

5 participants