Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw strings from ES6 tagged templates are incorrect #1841

Closed
gyson opened this issue May 29, 2015 · 3 comments
Closed

Raw strings from ES6 tagged templates are incorrect #1841

gyson opened this issue May 29, 2015 · 3 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@gyson
Copy link
Contributor

gyson commented May 29, 2015

I noticed that raw strings from tagged templates are incorrect when we have nested templates like following (iojs 2.1.0, V8 4.2.77.20):

function tag(strings) {
  return strings.raw
}
tag`1 ${ `2` } 3` // => expect [ '1', '3' ], but got [ '2', ' 3' ]

I test it in Chrome 43.0.2357.81 (V8 4.3.61.23) and works as expected.

Therefore, I guess it's a bug from V8 and it would be fixed when iojs upgrades to newer V8.

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label May 30, 2015
@ChALkeR
Copy link
Member

ChALkeR commented May 30, 2015

The above testcase works with the next branch.
#1807 #1632

I assume that this is fixed in 3.0 (v8 4.3.x).

@cjihrig
Copy link
Contributor

cjihrig commented May 30, 2015

If this is fixed in next, is anyone opposed to closing this?

@bnoordhuis
Copy link
Member

I'll close it, there's nothing actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

5 participants