Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Node.js benchmarks in the community CI #17359

Closed
gareth-ellis opened this issue Nov 27, 2017 · 4 comments
Closed

Running Node.js benchmarks in the community CI #17359

gareth-ellis opened this issue Nov 27, 2017 · 4 comments
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. performance Issues and PRs related to the performance of Node.js.

Comments

@gareth-ellis
Copy link
Member

Hello @nodejs/collaborators ,

The community benchmarking workgroup has been working to get an easy way to launch and test the impactof a PR using a subset of benchmarks, making use of the hardware that was donated by Intel.

We've had a number of people test this out, and now we're at the point where it would be useful (both for us from a testing/verification perspective, and for the rest of the community) to see more people trying this out.

We've documented the use in https://github.com/nodejs/benchmarking/blob/master/docs/core_benchmarks.md

So, the next time you have a PR that there is a concern whether it would impact performance (or even if you just want to give the benchmarks in the CI a go), take a look and report back.

If you run into issues, please tag @nodejs/benchmarking or raise an issue in the benchmarking repo.

Thanks!

@vsemozhetbyt vsemozhetbyt added the performance Issues and PRs related to the performance of Node.js. label Nov 27, 2017
@AndreasMadsen AndreasMadsen added the meta Issues and PRs related to the general management of the project. label Nov 27, 2017
@joyeecheung joyeecheung added the build Issues and PRs related to build files or the CI. label Nov 28, 2017
@joyeecheung
Copy link
Member

joyeecheung commented Nov 28, 2017

BTW: #16557 is still open (the CI is using the test double for HTTP benchmarks because it does not have wrk/autocannon installed.), in case anyone wants to pick it up (I assigned that to myself but I've been a bit busy to tackle this).

@gareth-ellis
Copy link
Member Author

I can take a look - if there's issues like that in the future, tagging the benchmarking team would notify a larger group of people and so hopefully someone can look. I'll comment in that issue

@mhdawson
Copy link
Member

The issue @joyeecheung mentioned should now be resolved.

@mhdawson
Copy link
Member

I think its in place and being used closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Development

No branches or pull requests

5 participants