Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running make test adds git untracked files #17271

Closed
Bamieh opened this issue Nov 23, 2017 · 3 comments
Closed

running make test adds git untracked files #17271

Bamieh opened this issue Nov 23, 2017 · 3 comments
Labels
test Issues and PRs related to the tests.

Comments

@Bamieh
Copy link
Contributor

Bamieh commented Nov 23, 2017 •
edited
Loading

Hello,

When i run the tests make -j4 test against the project, i get the following changes on git to be tracked on my development branch:

image

I believe we have to add those in the .gitignore or is this intended?

  • Branch: master branch
@vsemozhetbyt
Copy link
Contributor

It seems this may be fixed in the #17224

@Bamieh
Copy link
Contributor Author

Bamieh commented Nov 23, 2017

@vsemozhetbyt great!

@Bamieh Bamieh closed this as completed Nov 23, 2017
@Bamieh Bamieh reopened this Nov 23, 2017
@mscdex mscdex added the test Issues and PRs related to the tests. label Nov 23, 2017
@Bamieh
Copy link
Contributor Author

Bamieh commented Nov 25, 2017 •
edited
Loading

closing this since #17224 fixes this and has been merged with master.

@Bamieh Bamieh closed this as completed Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @Bamieh @vsemozhetbyt