Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky async-hooks/test-querywrap #16362

Closed
joyeecheung opened this issue Oct 21, 2017 · 3 comments
Closed

Flaky async-hooks/test-querywrap #16362

joyeecheung opened this issue Oct 21, 2017 · 3 comments
Labels
async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

  • Version: master
  • Platform: freebsd
  • Subsystem: async_hooks, test

Not sure if I have seen this recently. Sample

not ok 106 async-hooks/test-querywrap
  ---
  duration_ms: 2.94
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED (Signal: 11)
@joyeecheung joyeecheung added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 21, 2017
@joyeecheung
Copy link
Member Author

@nodejs/platform-freebsd @nodejs/async_hooks

@mscdex mscdex added async_hooks Issues and PRs related to the async hooks subsystem. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. labels Oct 21, 2017
@apapirovski
Copy link
Contributor

apapirovski commented Jan 2, 2018

Has anyone seen this fail recently? I believe there's been a bunch of work in terms of refactoring async hooks and that might've fixed this.

Running this in parallel produces no errors locally and I've certainly seen this fail on my system before.

/cc @addaleax @AndreasMadsen

@joyeecheung
Copy link
Member Author

joyeecheung commented Jan 3, 2018

@apapirovski I don't think I've seen this in the recent month, we can close this for now and reopen later if necessary.

BTW, it would be nice if we have a bot/script that walks through the CI and monitors reproductions of flaky tests...

EDIT: found nodejs/build#453, if we can get the test results integration working again we will be able to see the history of a specific test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants